Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Uptime] Add type row to monitor detail page #79556

Merged
merged 2 commits into from
Oct 6, 2020
Merged

[Uptime] Add type row to monitor detail page #79556

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ac2a8e0
Add type row to monitor detail page.
justinkambic Oct 5, 2020
6d25c6d
Merge branch 'master' into uptime_type-field-on-detail-page
kibanamachine Oct 5, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions x-pack/plugins/uptime/public/components/monitor/status_details/status_bar/status_bar.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,6 +76,14 @@ export const MonitorStatusBar: React.FC = () => {
</MonListDescription>
<MonListTitle>{MonitorIDLabel}</MonListTitle>
<MonListDescription data-test-subj="monitor-page-title">{monitorId}</MonListDescription>
{monitorStatus?.monitor?.type && (
<>
<MonListTitle aria-label={labels.typeAriaLabel}>{labels.typeLabel}</MonListTitle>
<MonListDescription data-test-subj="monitor-page-type">
{monitorStatus.monitor.type}
</MonListDescription>
</>
)}
<MonitorSSLCertificate tls={monitorStatus?.tls} />
<MonitorRedirects monitorStatus={monitorStatus} />
</EuiDescriptionList>
Expand Down
8 changes: 8 additions & 0 deletions x-pack/plugins/uptime/public/components/monitor/status_details/translations.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,14 @@ export const downLabel = i18n.translate(
}
);

export const typeLabel = i18n.translate('xpack.uptime.monitorStatusBar.type.label', {
defaultMessage: 'Type',
});

export const typeAriaLabel = i18n.translate('xpack.uptime.monitorStatusBar.type.ariaLabel', {
defaultMessage: 'Monitor type',
});

export const monitorUrlLinkAriaLabel = i18n.translate(
'xpack.uptime.monitorStatusBar.monitorUrlLinkAriaLabel',
{
Expand Down