Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Input controls crashes if index pattern is not available #79431

Merged
merged 5 commits into from
Oct 8, 2020
Merged

Input controls crashes if index pattern is not available #79431

merged 5 commits into from
Oct 8, 2020

Conversation

DianaDerevyankina
Copy link
Contributor

Closes #72664

Summary

Fixed error displaying if input control visualization misses an index pattern.

image

Checklist

Delete any items that are not applicable to this PR.

For maintainers

@DianaDerevyankina DianaDerevyankina added Feature:Input Control Input controls visualization v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.11.0 labels Oct 5, 2020
@DianaDerevyankina DianaDerevyankina self-assigned this Oct 5, 2020
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

page load bundle size

id before after diff
inputControlVis 154.0KB 155.8KB +1.8KB

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

alexwizp
alexwizp approved these changes Oct 7, 2020
View reviewed changes
Copy link
Contributor

@alexwizp alexwizp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Tested locally

@DianaDerevyankina DianaDerevyankina marked this pull request as ready for review October 8, 2020 07:44
@DianaDerevyankina DianaDerevyankina requested a review from a team October 8, 2020 07:44
stratoula
stratoula approved these changes Oct 8, 2020
View reviewed changes
Copy link
Contributor

@stratoula stratoula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally, no crashes and the error indicator seems to work fine. LGTM!

@stratoula
Copy link
Contributor

This is a bug fix, I would add the release_note: fix flag

@DianaDerevyankina DianaDerevyankina added release_note:fix v7.10.0 and removed release_note:skip Skip the PR/issue when compiling release notes v7.11.0 labels Oct 8, 2020
@DianaDerevyankina DianaDerevyankina merged commit 4dc6f3b into elastic:master Oct 8, 2020
@DianaDerevyankina DianaDerevyankina mentioned this pull request Oct 8, 2020
Merged
DianaDerevyankina added a commit to DianaDerevyankina/kibana that referenced this pull request Oct 8, 2020
@DianaDerevyankina
Input controls crashes if index pattern is not available (elastic#79431)
720021b 
* Input controls crashes if index pattern is not available

Closes elastic#72664

* Replace index pattern null type with undefined

* Move index pattern checks into FilterManager init function

* Rename indexPatternService to indexPatternsService to match other variables names
gmmorris added a commit to gmmorris/kibana that referenced this pull request Oct 8, 2020
@gmmorris
Merge branch 'master' into task-manager/health
7cd7ca6 
* master:
  [Telemetry] Telemetry tools check all `makeUsageCollector` calls (elastic#79840)
  Input controls crashes if index pattern is not available (elastic#79431)
DianaDerevyankina added a commit that referenced this pull request Oct 8, 2020
@DianaDerevyankina
Input controls crashes if index pattern is not available (#79431) (#7…
2549191 
…9979)

* Input controls crashes if index pattern is not available

Closes #72664

* Replace index pattern null type with undefined

* Move index pattern checks into FilterManager init function

* Rename indexPatternService to indexPatternsService to match other variables names
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexwizp alexwizp alexwizp approved these changes

@stratoula stratoula stratoula approved these changes

Assignees

@DianaDerevyankina DianaDerevyankina

Labels
Feature:Input Control Input controls visualization release_note:fix v7.10.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Input controls crashes if index pattern is not available
4 participants
@DianaDerevyankina @kibanamachine @stratoula @alexwizp