-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ML] Replace swim lane implementation with elastic-charts Heatmap #79315
Merged
Merged
Changes from 25 commits
Commits
Show all changes
26 commits
Select commit
Hold shift + click to select a range
38c3593
[ML] replace swim lane vis
darnautov d2c7bff
[ML] update swimlane_container, add colors constant
darnautov 577342c
[ML] update swimlane_container, add colors constant
darnautov 7ade2c3
[ML] update swimlane_container, add colors constant
darnautov 34a3995
Merge remote-tracking branch 'upstream/master' into ML-new-swimlane
darnautov c65888d
[ML] unfiltered label for Overall swim lane
darnautov f8b31f3
[ML] tooltip content
darnautov 76c1b08
[ML] fix styles, override legend styles
darnautov 42e70ba
[ML] hide timeline for overall swimlane on the Anomaly Explorer page
darnautov 1bc52a2
[ML] remove explorer_swimlane component
darnautov 0dc7b5b
[ML] remove dragselect dependency
darnautov 43291f6
[ML] fix types
darnautov 58e9ac6
[ML] fix tooltips, change mask fill to white
darnautov 54bab97
[ML] fix highlightedData
darnautov a7de8bc
[ML] maxLegendHeight, fix Y-axis tooltip
darnautov 622fbc8
[ML] clear selection
darnautov a97dfad
[ML] dataTestSubj
darnautov f34d0f3
[ML] remove jest snapshot for explorer_swimlane
darnautov d1d2c72
[ML] handle empty string label, fix translation key
darnautov 99b0717
[ML] better positioning for the loading indicator
darnautov 661aab6
[ML] update elastic/charts version
darnautov 3a98bce
Merge remote-tracking branch 'upstream/master' into ML-new-swimlane
darnautov 6e63215
[ML] fix getFormattedSeverityScore and showSwimlane condition
darnautov d30b08e
[ML] fix selector for functional test
darnautov f3c7a94
[ML] change the legend alignment
darnautov 7910908
[ML] update elastic charts
darnautov File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 change: 0 additions & 1 deletion
1
x-pack/plugins/ml/public/application/components/chart_tooltip/_chart_tooltip.scss
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 changes: 0 additions & 3 deletions
3
x-pack/plugins/ml/public/application/explorer/__snapshots__/explorer_swimlane.test.tsx.snap
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The
>
in the legend should actually be>=
to match these conditions? Could the condition in the legend labelling be changed in a follow-up?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for spotting this! yes, I'll adjust the legend labels in a follow-up PR.