Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[7.x] [ML] Limit exposing shared static code through ml/public/index.ts. (#77745) #79252

Merged
merged 1 commit into from
Oct 2, 2020

Conversation

walterra
Copy link
Contributor

@walterra walterra commented Oct 2, 2020

Backports the following commits to 7.x:

…lastic#77745)

- Clean up lodash imports.
- Import types only where applicable.
- Reduce page load bundle size by fetching more code asynchronously.
# Conflicts:
#	x-pack/plugins/transform/public/app/sections/transform_management/components/transform_list/expanded_row.test.tsx
@walterra walterra self-assigned this Oct 2, 2020
@walterra walterra added the :ml label Oct 2, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui (:ml)

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

@kbn/optimizer bundle module count

id before after diff
ml 1452 1215 -237
transform 515 335 -180
total -417

async chunks size

id before after diff
ml 8.9MB 10.5MB ⚠️ +1.6MB
transform 1.2MB 1.2MB -70.2KB
total ⚠️ +1.6MB

distributable file count

id before after diff
default 45861 45882 +21

page load bundle size

id before after diff
ml 739.6KB 40.3KB -699.4KB
transform 25.3KB 25.5KB +229.0B
total -699.1KB

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@walterra walterra merged commit e80f4e5 into elastic:7.x Oct 2, 2020
@walterra walterra deleted the backport/7.x/pr-77745 branch October 2, 2020 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants