Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ML] Only adjust the bounds of SMV if annotations are visible #79210

Merged
merged 2 commits into from
Oct 5, 2020
Merged

[ML] Only adjust the bounds of SMV if annotations are visible #79210

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7663481
[ML] Only adjust the bounds if annotations are visible
qn895 Oct 1, 2020
c371a56
Merge branch 'master' into ml-smv-fix-y-range-if-annotions-hidden
kibanamachine Oct 5, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .../ml/public/application/timeseriesexplorer/components/timeseries_chart/timeseries_chart.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -672,7 +672,7 @@ class TimeseriesChartIntl extends Component {

// if annotations are present, we extend yMax to avoid overlap
// between annotation labels, chart lines and anomalies.
if (focusAnnotationData && focusAnnotationData.length > 0) {
if (showAnnotations && focusAnnotationData && focusAnnotationData.length > 0) {
const levels = getAnnotationLevels(focusAnnotationData);
const maxLevel = d3.max(Object.keys(levels).map((key) => levels[key]));
// TODO needs revisiting to be a more robust normalization
Expand Down