[ML] Model management UI fixes and enhancements #79072
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
darnautov
added
:ml
v8.0.0
release_note:skip
|
Pinging @elastic/ml-ui (:ml) |
| import { formatDate } from '@elastic/eui/lib/services/format'; | ||
| import { TIME_FORMAT } from '../constants/time_format'; | ||
|
|
||
| export const timeFormatter = (value: number) => { |
There was a problem hiding this comment.
this is very similar to the functions in https://github.com/elastic/kibana/blob/master/x-pack/plugins/ml/public/application/util/date_utils.ts
Also we have quite a few places that have almost identical functions to this, which are local to the file and not shared.
plus a handful of places where we're doing something like this:
I think it be worth moving date_utils.ts to common and merging with this file and then changing all uses of formatDate were it's being using with TIME_FORMAT
I don't know if all of that work would be too out of scope for this PR, if so, then maybe just the merging of date_utils.ts would be enough for now.
There was a problem hiding this comment.
Refactored in 35b1c8c
- Moved
date_utilsto common - Introduced a
timeFormatterbased onTIME_FORMATindate_utilsand replaced all duplicates
💚 Build SucceededMetrics [docs]async chunks size
distributable file count
History
To update your PR or re-run it, just comment with: |
phillipb
added a commit
to phillipb/kibana
that referenced
this pull request
Oct 1, 2020
…aly-detection-partition-field * 'master' of github.com:elastic/kibana: (76 commits) Fix z-index of KQL Suggestions dropdown (elastic#79184) [babel] remove unused/unneeded babel plugins (elastic#79173) [Search] Fix timeout upgrade link (elastic#79045) Always Show Embeddable Panel Header in Edit Mode (elastic#79152) [Ingest]: add more test for transform index (elastic#79154) [ML] DF Analytics: Collapsable sections on results pages (elastic#76641) [Fleet] Fix agent policy change action migration (elastic#79046) [Ingest Manager] Match package spec `dataset`->`data_stream` and `config_templates`->`policy_templates` renaming (elastic#78699) Revert "[Metrics UI] Add ability to override datafeeds and job config for partition field (elastic#78875)" [ML] Update transform cloning to include description and new fields (elastic#78364) chore(NA): remove non existing plugin paths from case api integration tests (elastic#79127) [Ingest Manager] Ensure we trigger agent policy updated event when we bump revision. (elastic#78836) [Metrics UI] Display No Data context.values as [NO DATA] (elastic#78038) [Monitoring] Missing data alert (elastic#78208) [Lens] Fix embeddable title and description for reporting and dashboard tooltip (elastic#78767) [Lens] Consistent Drag and Drop styles (elastic#78674) [ML] Model management UI fixes and enhancements (elastic#79072) [Metrics UI] Add ability to override datafeeds and job config for partition field (elastic#78875) [Security Solution]Fix basepath used by endpoint telemetry tests (elastic#79027) update rum agent version which contains longtasks (elastic#79105) ...
darnautov
added a commit
to darnautov/kibana
that referenced
this pull request
Oct 2, 2020
* [ML] link to edit pipeline * [ML] view training data link * [ML] format stats and configs * [ML] refactor date_utils * [ML] fix types * [ML] change "View" icon and label * [ML] revert label change
darnautov
added a commit
that referenced
this pull request
Oct 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up on #74978.
Fixes date formatting
Wraps JSON values in the EUI code block component
"View training data" URL navigates to the results page with predefined
is_trainingvalue in the queryIntroduces "Edit" URL to the Ingest Pipeline edit page
Checklist