Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ML] Improve calendar ics file parsing #78986

Merged
merged 1 commit into from
Oct 1, 2020
Merged

[ML] Improve calendar ics file parsing #78986

merged 1 commit into from
Oct 1, 2020

Conversation

jgowdyelastic
Copy link
Member

@jgowdyelastic jgowdyelastic commented Sep 30, 2020 •
edited
Loading

The icalendar library used to parse ICS files fails if the last line does not contain a new line character.

Fixes #74052

@jgowdyelastic jgowdyelastic added bug Fixes for quality problems that affect the customer experience review release_note:fix :ml v8.0.0 v7.10.0 labels Sep 30, 2020
@jgowdyelastic jgowdyelastic requested a review from a team as a code owner September 30, 2020 16:27
@jgowdyelastic jgowdyelastic self-assigned this Sep 30, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui (:ml)

peteharverson
peteharverson approved these changes Sep 30, 2020
View reviewed changes
Copy link
Contributor

@peteharverson peteharverson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and LGTM

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

async chunks size

id value diff baseline
ml 10.5MB +10.0B 10.5MB

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

alvarezmelissa87
alvarezmelissa87 approved these changes Sep 30, 2020
View reviewed changes
Copy link
Contributor

@alvarezmelissa87 alvarezmelissa87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ⚡

@jgowdyelastic jgowdyelastic merged commit 2135340 into elastic:master Oct 1, 2020
@jgowdyelastic jgowdyelastic deleted the improve-calendar-ics-importing branch October 1, 2020 14:16
@jgowdyelastic jgowdyelastic mentioned this pull request Oct 1, 2020
Merged
jgowdyelastic added a commit to jgowdyelastic/kibana that referenced this pull request Oct 1, 2020
@jgowdyelastic
[ML] Improve calendar ics file parsing (elastic#78986)
0f09a83
jgowdyelastic added a commit that referenced this pull request Oct 2, 2020
@jgowdyelastic
[ML] Improve calendar ics file parsing (#78986) (#79125)
e993559
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peteharverson peteharverson peteharverson approved these changes

@alvarezmelissa87 alvarezmelissa87 alvarezmelissa87 approved these changes

Assignees

@jgowdyelastic jgowdyelastic

Labels
bug Fixes for quality problems that affect the customer experience :ml release_note:fix review v7.10.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[ML] Failed to import calendar events using .ics
5 participants
@jgowdyelastic @elasticmachine @kibanamachine @alvarezmelissa87 @peteharverson