Fix #7678 Add tooltip to legend in visualization #7890
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
|
@ck-lee Thanks for submitting this PR! I'll review this week. |
|
LGTM! Here's a screenshot, for the record:
|
| @@ -15,7 +15,8 @@ | |||
| <div | |||
| ng-click="showDetails = !showDetails" | |||
| ng-class="showDetails ? 'legend-value-full' : 'legend-value-truncate'" | |||
| class="legend-value-title"> | |||
| class="legend-value-title" | |||
| tooltip="{{legendData.label}}"> | |||
There was a problem hiding this comment.
last > should be in new line and aligned with <div
|
LGTM except for the minor style comment |
Minor code styling after review
|
@ppisljar Please review |
|
LGTM |
|
Thank you @ck-lee ! |
airow
pushed a commit
to airow/kibana
that referenced
this pull request
Feb 16, 2017
Fix elastic#7678 Add tooltip to legend in visualization Former-commit-id: 57f338a
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7678
My first PR for Kibana. I implemented the tooltip to always show, instead of only show if the label is too long. I thought the UX is better this way and with a simpler implementation. Happy to experiment otherwise.