Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Drilldowns][Docs] Communicate the visualization types that support drilldowns #78761

Merged
merged 5 commits into from
Oct 1, 2020
Merged

[Drilldowns][Docs] Communicate the visualization types that support drilldowns #78761

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
177411f
document panel support
Dosant Sep 29, 2020
989927a
improve
Dosant Sep 29, 2020
0e4e2f8
improve
Dosant Sep 29, 2020
4ac129a
Merge branch 'master' of github.com:elastic/kibana into docs/drilldow…
Dosant Sep 30, 2020
d7bcc7f
review updates
Dosant Sep 30, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 22 additions & 0 deletions docs/user/dashboard/dashboard-drilldown.asciidoc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,3 +74,25 @@ image::images/drilldown_on_panel.png[Drilldown on pie chart that navigates to an
+
You are navigated to your destination dashboard. Verify that the search query, filters,
and time range are carried over.

[float]
[[dashboard-drilldown-supported-panels]]
==== Supported panels
Dosant marked this conversation as resolved.
Show resolved Hide resolved

Following panels support dashboard drilldown:
Dosant marked this conversation as resolved.
Show resolved Hide resolved

* Lens
* Maps
* Visualize
** Area
** Data table
** Heat Map
** Horizontal Bar
** Line
** Pie
** TSVB
** Tag Cloud
** Timelion
** Vega
** Vertical Bar

6 changes: 6 additions & 0 deletions docs/user/dashboard/drilldowns.asciidoc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,12 @@ For a comparison of the Elastic subscription levels,
see https://www.elastic.co/subscriptions[the subscription page].
==============================================

[NOTE]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this note necessary as the individual pages have a list of supported panels?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I removed the note.
I thought it make sense to emphasise that not all panels support drilldown and then that support is different per panel type. But I guess this is indeed redundant.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My bigger concern was that there were back-to-back notes, which can be difficult to read. Another option is to put the text about panel support above the note that starts with "Some action types" . But don't use Note format for the panel support text.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see. I am good with removing! Thanks for feedback

==============================================
Not all panel types support drilldowns.
Refer to sub-page of a specific drilldown action to learn about supported panels.
==============================================

[float]
[[code-drilldowns]]
=== Code drilldowns
Expand Down
17 changes: 17 additions & 0 deletions docs/user/dashboard/url-drilldown.asciidoc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -239,6 +239,23 @@ Tip: Consider using <<helpers, date>> helper for date formatting.

|===

[float]
[[url-drilldown-supported-panels]]
==== Supported panels
Dosant marked this conversation as resolved.
Show resolved Hide resolved

Following panels support URL drilldown:

* Lens
* Visualize
** Area
** Data table
** Heat Map
** Horizontal Bar
** Line
** Pie
** Tag Cloud
** Vertical Bar

[float]
[[disable]]
==== Disable URL drilldown
Expand Down