Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Functional] Add retry on custom formatter test of TSVB #78729

Merged
merged 2 commits into from
Oct 2, 2020
Merged

[Functional] Add retry on custom formatter test of TSVB #78729

merged 2 commits into from
Oct 2, 2020

Conversation

stratoula
Copy link
Contributor

@stratoula stratoula commented Sep 29, 2020 •
edited
Loading

Summary

Closes #76185
This fails only on the cloud. Couldn't replicate it but I think that the problem is that sometimes it adds the custom formatted but the value on the chart is updated with a delay. So I think that a retry can help here.

https://internal-ci.elastic.co/job/elastic+estf-cloud-kibana-flaky-test-runner/135/

Checklist

@stratoula stratoula changed the title [Functional] Add retry on custom formatter test [Functional] Add retry on custom formatter test of TSVB Sep 29, 2020
@stratoula stratoula added Feature:TSVB TSVB (Time Series Visual Builder) test-cloud Team:Visualizations Visualization editors, elastic-charts and infrastructure release_note:skip Skip the PR/issue when compiling release notes v8.0.0 v7.10.0 labels Sep 29, 2020
@stratoula stratoula marked this pull request as ready for review September 29, 2020 09:40
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app (Team:KibanaApp)

@stratoula stratoula requested a review from liza-mae September 29, 2020 09:41
@stratoula
Copy link
Contributor Author

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

liza-mae
liza-mae approved these changes Oct 2, 2020
View reviewed changes
Copy link
Contributor

@liza-mae liza-mae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stratoula stratoula merged commit 1b61cc6 into elastic:master Oct 2, 2020
stratoula added a commit to stratoula/kibana that referenced this pull request Oct 2, 2020
@stratoula @elasticmachine
[Functional] Add retry on custom formatter test (elastic#78729)
3b82c32 
Co-authored-by: Elastic Machine <[email protected]>
@stratoula stratoula mentioned this pull request Oct 2, 2020
Merged
stratoula added a commit that referenced this pull request Oct 2, 2020
@stratoula @elasticmachine
[Functional] Add retry on custom formatter test (#78729) (#79250)
ac57149 
Co-authored-by: Elastic Machine <[email protected]>

Co-authored-by: Elastic Machine <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liza-mae liza-mae liza-mae approved these changes

Assignees
No one assigned
Labels
Feature:TSVB TSVB (Time Series Visual Builder) release_note:skip Skip the PR/issue when compiling release notes Team:Visualizations Visualization editors, elastic-charts and infrastructure test-cloud v7.10.0 v8.0.0
Projects
None yet
Milestone
No milestone
4 participants
@stratoula @elasticmachine @kibanamachine @liza-mae