Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Security Solution]Adds retryability feature #78611

Merged
merged 1 commit into from
Sep 29, 2020

Conversation

MadameSheema
Copy link
Member

@MadameSheema MadameSheema commented Sep 28, 2020

Summary

As we know UI tests are flaky by nature. Lately we have faced some situations with some tests failed due to a slow connection with the server.

In order to avoid noise and to have tests skipped for a false positive, in this PR we are activating tests retries, a new functionality available in v5. With this new functionality activated and configured, Cypress will retry failed tests up to 2 additional times (for a total of 3 attempts) before potentially being marked as a failed test.

@MadameSheema MadameSheema self-assigned this Sep 28, 2020
@MadameSheema MadameSheema added v7.10.0 v8.0.0 Feature:Detection Rules Security Solution rules and Detection Engine release_note:skip Skip the PR/issue when compiling release notes and removed Feature:Detection Rules Security Solution rules and Detection Engine labels Sep 28, 2020
@MadameSheema MadameSheema marked this pull request as ready for review September 28, 2020 17:42
@MadameSheema MadameSheema requested review from a team as code owners September 28, 2020 17:42
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

  • 💔 Build #77456 failed a98d36939e3745a15e258ed1631db1e5104fe2b1

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Copy link
Contributor

@patrykkopycinski patrykkopycinski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💪

@MadameSheema MadameSheema merged commit 87b25d5 into elastic:master Sep 29, 2020
@MadameSheema MadameSheema deleted the retryability branch September 29, 2020 06:58
MadameSheema added a commit to MadameSheema/kibana that referenced this pull request Sep 29, 2020
gmmorris added a commit to gmmorris/kibana that referenced this pull request Sep 29, 2020
* master: (365 commits)
  making expression debug info serializable (elastic#78727)
  fix lodahs imports in app-arch code (elastic#78582)
  Make Field a React.lazy export (elastic#78483)
  [Security Solution] Improves detections tests (elastic#77295)
  [TSVB] Different field format on different series is ignored (elastic#78138)
  RFC: Improve saved object migrations (elastic#66056)
  [Security Solution] Fixes url timeline flaky test (elastic#78556)
  adds retryability feature (elastic#78611)
  Aligns several module versions across the repository (elastic#78327)
  Empty prompt and loading spinner for service map (elastic#78382)
  Change progress bar to spinner (elastic#78460)
  [QA][Code Coverage] Coverage teams lookup w/o Additional Config (elastic#77111)
  Slim down core bundle (elastic#75912)
  [Alerting] retry internal OCC calls within alertsClient (elastic#77838)
  [kbn/optimizer] only build xpack examples when building xpack plugins (elastic#78656)
  [Ingest Manager] Ingest setup upgrade (elastic#78081)
  [Ingest Manager] Surface saved object client 10,000 limitation to bulk actions UI (elastic#78520)
  fix name without a category or if field end with .text (elastic#78655)
  [Security Solution] [Detections] Log message enhancements (elastic#78429)
  [ML]DF Analytics exploration: default filter of results page by `defaultIsTraining` value in url (elastic#78303)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release_note:skip Skip the PR/issue when compiling release notes v7.10.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants