Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve invalid field error message at search.aggs.param_types.field #78587

Merged
merged 5 commits into from
Sep 30, 2020
Merged

Improve invalid field error message at search.aggs.param_types.field #78587

Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
1e86bfe
Improve error message
kertal Sep 28, 2020
d6914dc
Remove debug code
kertal Sep 28, 2020
3e8212b
Improve error message
kertal Sep 29, 2020
a542b97
Fix i18n
kertal Sep 29, 2020
d82c35e
use aggConfig.type.title
kertal Sep 29, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/plugins/data/common/search/aggs/param_types/field.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,7 @@ export class FieldParamType extends BaseParamType {
defaultMessage:
'Saved {fieldParameter} parameter is now invalid. Please select a new field.',
values: {
fieldParameter: '"field"',
fieldParameter: `"${fieldName}"`,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this is targeting a minor, not a patch, we can create new translations. My preference would be a message like Saved field "order_date" is invalid for use with the "terms" aggregation. Please select a new field.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wylieconlon done. much better this way 👍
Discover_-_Elastic

},
}
)
Expand Down