[Visualize] Horizontal Bar Graph Visualizations have Vertical Bar Graph Type #78536

VladLasitsa · 2020-09-25T14:19:09Z

Summary

Fixes the issue with incorrect chart type icon and simplifies the process of defining the current chart type.
AFAIK it's only needed for showing Show values on chart switch box which affects only bar chart type:

Here is the initial angular code, which I think didn't have any effect besides that switch box.

Related recent PR #66375

Checklist

Delete any items that are not applicable to this PR.

Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
Documentation was added for features that require explanation or tutorials
Unit or functional tests were updated or added to match the most common scenarios
This was checked for keyboard-only and screenreader accessibility
This renders correctly on smaller devices using a responsive layout. (You can test this in your browser
This was checked for cross-browser compatibility

For maintainers

This was checked for breaking API changes and was labeled appropriately

… of vis

src/plugins/vis_type_vislib/public/components/options/metrics_axes/index.tsx

elasticmachine · 2020-10-01T15:17:23Z

Pinging @elastic/kibana-app (Team:KibanaApp)

stratoula

LGTM, tested locally, my new horizontal charts have the correct type now 🎉

VladLasitsa · 2020-10-05T13:41:55Z

@elasticmachine merge upstream

alexwizp

LGTM! Thank you

kibanamachine · 2020-10-05T15:09:36Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: afd996e

Metrics [docs]

@kbn/optimizer bundle module count

id	before	after	diff
`alerts`	-	26	+26
`apm`	-	1276	+1276
`beatsManagement`	-	302	+302
`canvas`	-	1132	+1132
`cloud`	-	6	+6
`crossClusterReplication`	-	159	+159
`dashboardEnhanced`	-	26	+26
`dashboardMode`	-	4	+4
`dataEnhanced`	-	17	+17
`discoverEnhanced`	-	11	+11
`embeddableEnhanced`	-	11	+11
`enterpriseSearch`	-	250	+250
`features`	-	11	+11
`fileUpload`	-	21	+21
`globalSearch`	-	23	+23
`globalSearchBar`	-	13	+13
`globalSearchProviders`	-	8	+8
`graph`	-	169	+169
`grokdebugger`	-	75	+75
`indexLifecycleManagement`	-	206	+206
`indexManagement`	-	509	+509
`infra`	-	1147	+1147
`ingestManager`	-	544	+544
`ingestPipelines`	-	493	+493
`lens`	-	563	+563
`licenseManagement`	-	145	+145
`licensing`	-	12	+12
`lists`	-	128	+128
`logstash`	-	190	+190
`maps`	-	618	+618
`mapsLegacyLicensing`	-	4	+4
`ml`	-	1222	+1222
`monitoring`	-	635	+635
`observability`	-	96	+96
`painlessLab`	-	40	+40
`remoteClusters`	-	141	+141
`reporting`	-	45	+45
`rollup`	-	179	+179
`searchprofiler`	-	87	+87
`security`	-	458	+458
`securitySolution`	-	1998	+1998
`snapshotRestore`	-	168	+168
`spaces`	-	237	+237
`transform`	-	335	+335
`triggers_actions_ui`	-	274	+274
`uiActionsEnhanced`	-	134	+134
`upgradeAssistant`	-	117	+117
`uptime`	-	655	+655
`urlDrilldown`	-	8	+8
`watcher`	-	237	+237
total			+15165

async chunks size

id	before	after	diff
`apm`	-	4.2MB	⚠️ +4.2MB
`beatsManagement`	-	683.5KB	⚠️ +683.5KB
`canvas`	-	1.5MB	⚠️ +1.5MB
`crossClusterReplication`	-	456.5KB	⚠️ +456.5KB
`enterpriseSearch`	-	428.6KB	⚠️ +428.6KB
`fileUpload`	-	574.9KB	⚠️ +574.9KB
`graph`	-	1.3MB	⚠️ +1.3MB
`grokdebugger`	-	568.8KB	⚠️ +568.8KB
`indexLifecycleManagement`	-	231.7KB	⚠️ +231.7KB
`indexManagement`	-	1.6MB	⚠️ +1.6MB
`infra`	-	3.8MB	⚠️ +3.8MB
`ingestManager`	-	1.1MB	⚠️ +1.1MB
`ingestPipelines`	-	812.9KB	⚠️ +812.9KB
`lens`	-	1.0MB	⚠️ +1.0MB
`licenseManagement`	-	167.5KB	+167.5KB
`logstash`	-	213.4KB	⚠️ +213.4KB
`maps`	-	3.2MB	⚠️ +3.2MB
`ml`	-	10.6MB	⚠️ +10.6MB
`monitoring`	-	1.2MB	⚠️ +1.2MB
`observability`	-	163.2KB	+163.2KB
`painlessLab`	-	38.7KB	+38.7KB
`remoteClusters`	-	227.8KB	⚠️ +227.8KB
`rollup`	-	323.3KB	⚠️ +323.3KB
`searchprofiler`	-	705.1KB	⚠️ +705.1KB
`security`	-	1.0MB	⚠️ +1.0MB
`securitySolution`	-	10.3MB	⚠️ +10.3MB
`snapshotRestore`	-	622.6KB	⚠️ +622.6KB
`spaces`	-	45.5KB	+45.5KB
`transform`	-	1.2MB	⚠️ +1.2MB
`triggers_actions_ui`	-	1.5MB	⚠️ +1.5MB
`upgradeAssistant`	-	179.8KB	+179.8KB
`uptime`	-	1.7MB	⚠️ +1.7MB
`watcher`	-	1.0MB	⚠️ +1.0MB
total			⚠️ +52.4MB

distributable file count

id	before	after	diff
`default`	-	47087	+47087

miscellaneous assets size

id	before	after	diff
`apm`	-	49.0KB	+49.0KB
`enterpriseSearch`	-	834.9KB	⚠️ +834.9KB
`maps`	-	978.6KB	⚠️ +978.6KB
`securitySolution`	-	326.0KB	⚠️ +326.0KB
`triggers_actions_ui`	-	27.7KB	+27.7KB
total			⚠️ +2.2MB

page load bundle size

id	before	after	diff
`alerts`	-	89.8KB	+89.8KB
`apm`	-	44.3KB	+44.3KB
`beatsManagement`	-	169.1KB	+169.1KB
`canvas`	-	1.0MB	⚠️ +1.0MB
`cloud`	-	5.9KB	+5.9KB
`crossClusterReplication`	-	49.2KB	+49.2KB
`dashboardEnhanced`	-	43.1KB	+43.1KB
`dashboardMode`	-	7.5KB	+7.5KB
`dataEnhanced`	-	34.3KB	+34.3KB
`discoverEnhanced`	-	29.2KB	+29.2KB
`embeddableEnhanced`	-	25.5KB	+25.5KB
`enterpriseSearch`	-	20.0KB	+20.0KB
`features`	-	15.8KB	+15.8KB
`fileUpload`	-	9.5KB	+9.5KB
`globalSearch`	-	27.9KB	+27.9KB
`globalSearchBar`	-	29.0KB	+29.0KB
`globalSearchProviders`	-	10.3KB	+10.3KB
`graph`	-	15.8KB	+15.8KB
`grokdebugger`	-	11.5KB	+11.5KB
`indexLifecycleManagement`	-	89.9KB	+89.9KB
`indexManagement`	-	122.8KB	+122.8KB
`infra`	-	178.6KB	+178.6KB
`ingestManager`	-	511.7KB	⚠️ +511.7KB
`ingestPipelines`	-	42.0KB	+42.0KB
`lens`	-	76.0KB	+76.0KB
`licenseManagement`	-	26.2KB	+26.2KB
`licensing`	-	23.1KB	+23.1KB
`lists`	-	164.7KB	+164.7KB
`logstash`	-	37.6KB	+37.6KB
`maps`	-	164.4KB	+164.4KB
`mapsLegacyLicensing`	-	5.1KB	+5.1KB
`ml`	-	58.5KB	+58.5KB
`monitoring`	-	222.7KB	⚠️ +222.7KB
`observability`	-	52.4KB	+52.4KB
`painlessLab`	-	160.9KB	+160.9KB
`remoteClusters`	-	35.5KB	+35.5KB
`reporting`	-	164.5KB	+164.5KB
`rollup`	-	80.3KB	+80.3KB
`searchprofiler`	-	50.9KB	+50.9KB
`security`	-	163.3KB	+163.3KB
`securitySolution`	-	587.1KB	⚠️ +587.1KB
`snapshotRestore`	-	62.5KB	+62.5KB
`spaces`	-	364.2KB	⚠️ +364.2KB
`transform`	-	25.4KB	+25.4KB
`triggers_actions_ui`	-	148.0KB	+148.0KB
`uiActionsEnhanced`	-	320.7KB	⚠️ +320.7KB
`upgradeAssistant`	-	64.7KB	+64.7KB
`uptime`	-	25.2KB	+25.2KB
`urlDrilldown`	-	18.7KB	+18.7KB
`visTypeVislib`	222.7KB	222.5KB	-211.0B
`watcher`	-	27.9KB	+27.9KB
total			⚠️ +5.6MB

Saved Objects .kibana field count

id	before	after	diff
`_data_stream_timestamp`	-	1	+1
`action`	-	5	+5
`action_task_params`	-	3	+3
`alert`	-	30	+30
`apm-indices`	-	8	+8
`application_usage_daily`	-	2	+2
`canvas-element`	-	8	+8
`canvas-workpad`	-	5	+5
`canvas-workpad-template`	-	8	+8
`cases`	-	32	+32
`cases-comments`	-	17	+17
`cases-configure`	-	14	+14
`cases-user-actions`	-	10	+10
`config`	-	2	+2
`dashboard`	-	17	+17
`endpoint:user-artifact`	-	10	+10
`endpoint:user-artifact-manifest`	-	5	+5
`epm-packages`	-	14	+14
`exception-list`	-	39	+39
`exception-list-agnostic`	-	39	+39
`file-upload-telemetry`	-	2	+2
`fleet-agent-actions`	-	9	+9
`fleet-agent-events`	-	11	+11
`fleet-agents`	-	25	+25
`fleet-enrollment-api-keys`	-	10	+10
`graph-workspace`	-	9	+9
`index-pattern`	-	3	+3
`ingest_manager_settings`	-	6	+6
`ingest-agent-policies`	-	11	+11
`ingest-outputs`	-	10	+10
`ingest-package-policies`	-	35	+35
`kql-telemetry`	-	3	+3
`lens`	-	7	+7
`lens-ui-telemetry`	-	5	+5
`map`	-	7	+7
`ml-telemetry`	-	3	+3
`monitoring-telemetry`	-	2	+2
`namespace`	-	1	+1
`namespaces`	-	1	+1
`originId`	-	1	+1
`query`	-	6	+6
`references`	-	4	+4
`sample-data-telemetry`	-	3	+3
`search`	-	9	+9
`siem-detection-engine-rule-actions`	-	8	+8
`siem-detection-engine-rule-status`	-	12	+12
`siem-ui-timeline`	-	90	+90
`siem-ui-timeline-note`	-	8	+8
`siem-ui-timeline-pinned-event`	-	7	+7
`space`	-	9	+9
`telemetry`	-	9	+9
`timelion-sheet`	-	13	+13
`tsvb-validation-telemetry`	-	2	+2
`type`	-	1	+1
`ui-metric`	-	2	+2
`updated_at`	-	1	+1
`upgrade-assistant-reindex-operation`	-	18	+18
`upgrade-assistant-telemetry`	-	13	+13
`url`	-	6	+6
`visualization`	-	9	+9
total			+660

History

💛 Build #78786 was flaky 7d95bf6
💚 Build #77370 succeeded aee2b2e
💔 Build #77215 failed a96d784
💔 Build #77211 failed 23634a6

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

…ph Type (elastic#78536) * Fixed useEffect in metric_axes. Update type in params instead of type of vis * Fixed tests * Fixed tests * Update current chart type definition Co-authored-by: sulemanof <[email protected]> Co-authored-by: Kibana Machine <[email protected]>

…ph Type (#78536) (#79500) * Fixed useEffect in metric_axes. Update type in params instead of type of vis * Fixed tests * Fixed tests * Update current chart type definition Co-authored-by: sulemanof <[email protected]> Co-authored-by: Kibana Machine <[email protected]> Co-authored-by: sulemanof <[email protected]> Co-authored-by: Kibana Machine <[email protected]>

Fixed useEffect in metric_axes. Update type in params instead of type…

23634a6

… of vis

VladLasitsa requested review from ppisljar and sulemanof September 25, 2020 14:19

VladLasitsa added 2 commits September 25, 2020 17:55

Fixed tests

a96d784

Fixed tests

aee2b2e

sulemanof reviewed Sep 29, 2020

View reviewed changes

src/plugins/vis_type_vislib/public/components/options/metrics_axes/index.tsx Outdated Show resolved Hide resolved

sulemanof added 2 commits October 1, 2020 17:15

Merge remote-tracking branch 'upstream/master' into elastic#77936

600b909

Update current chart type definition

7d95bf6

sulemanof requested review from timroes, stratoula and flash1293 October 1, 2020 15:16

sulemanof added release_note:skip Skip the PR/issue when compiling release notes Team:Visualizations Visualization editors, elastic-charts and infrastructure v7.10.0 v8.0.0 labels Oct 1, 2020

sulemanof marked this pull request as ready for review October 1, 2020 15:17

sulemanof requested a review from a team October 1, 2020 15:17

stratoula approved these changes Oct 2, 2020

View reviewed changes

Merge branch 'master' into elastic#77936

afd996e

alexwizp approved these changes Oct 5, 2020

View reviewed changes

VladLasitsa merged commit 90b6442 into elastic:master Oct 5, 2020

VladLasitsa mentioned this pull request Oct 5, 2020

[7.x] [Visualize] Horizontal Bar Graph Visualizations have Vertical Bar Graph Type (#78536) #79500

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Visualize] Horizontal Bar Graph Visualizations have Vertical Bar Graph Type #78536

[Visualize] Horizontal Bar Graph Visualizations have Vertical Bar Graph Type #78536

VladLasitsa commented Sep 25, 2020 •

edited by sulemanof

Loading

elasticmachine commented Oct 1, 2020

stratoula left a comment

VladLasitsa commented Oct 5, 2020

alexwizp left a comment

kibanamachine commented Oct 5, 2020

[Visualize] Horizontal Bar Graph Visualizations have Vertical Bar Graph Type #78536

[Visualize] Horizontal Bar Graph Visualizations have Vertical Bar Graph Type #78536

Conversation

VladLasitsa commented Sep 25, 2020 • edited by sulemanof Loading

Summary

Checklist

For maintainers

elasticmachine commented Oct 1, 2020

stratoula left a comment

Choose a reason for hiding this comment

VladLasitsa commented Oct 5, 2020

alexwizp left a comment

Choose a reason for hiding this comment

kibanamachine commented Oct 5, 2020

💚 Build Succeeded

Metrics [docs]

@kbn/optimizer bundle module count

async chunks size

distributable file count

miscellaneous assets size

page load bundle size

Saved Objects .kibana field count

History

VladLasitsa commented Sep 25, 2020 •

edited by sulemanof

Loading