Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert VectorLayer to typescript #78490

Merged
merged 18 commits into from
Oct 2, 2020
Merged

Convert VectorLayer to typescript #78490

merged 18 commits into from
Oct 2, 2020

Conversation

nreese
Copy link
Contributor

@nreese nreese commented Sep 24, 2020

Convert VectorLayer to typescript

@nreese nreese added chore [Deprecated-Use Team:Presentation]Team:Geo Former Team Label for Geo Team. Now use Team:Presentation v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.10.0 labels Sep 24, 2020
@nreese nreese requested a review from a team as a code owner September 24, 2020 20:33
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-gis (Team:Geo)

@nreese
Copy link
Contributor Author

nreese commented Sep 25, 2020

@elasticmachine merge upstream

@nreese
Copy link
Contributor Author

nreese commented Sep 28, 2020

@elasticmachine merge upstream

@nreese
Copy link
Contributor Author

nreese commented Sep 28, 2020

@elasticmachine merge upstream

@nreese
Copy link
Contributor Author

nreese commented Sep 29, 2020

@elasticmachine merge upstream

@nreese
Copy link
Contributor Author

nreese commented Oct 1, 2020

@elasticmachine merge upstream

thomasneirynck
thomasneirynck approved these changes Oct 1, 2020
View reviewed changes
Copy link
Contributor

@thomasneirynck thomasneirynck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wow, really big effort, thank you.

There's a few comments, don't feel strongly about any.

x-pack/plugins/maps/public/classes/layers/layer.test.ts Show resolved Hide resolved
x-pack/plugins/maps/public/classes/layers/layer.tsx Outdated Show resolved Hide resolved
x-pack/plugins/maps/public/classes/layers/layer.tsx Outdated Show resolved Hide resolved
x-pack/plugins/maps/public/classes/layers/tiled_vector_layer/tiled_vector_layer.tsx Show resolved Hide resolved
x-pack/plugins/maps/public/classes/layers/tiled_vector_layer/tiled_vector_layer.tsx Show resolved Hide resolved
x-pack/plugins/maps/public/classes/layers/vector_layer/vector_layer.tsx Show resolved Hide resolved
x-pack/plugins/maps/public/classes/layers/vector_layer/vector_layer.d.ts Show resolved Hide resolved
@nreese nreese requested a review from a team as a code owner October 1, 2020 20:43
@nreese nreese requested a review from a team October 1, 2020 20:43
@nreese nreese requested review from a team as code owners October 1, 2020 20:43
@botelastic botelastic bot added Feature:Embedding Embedding content via iFrame Team:Fleet Team label for Observability Data Collection Fleet team labels Oct 1, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/ingest-management (Team:Ingest Management)

@nreese nreese removed request for a team October 1, 2020 20:48
@nreese
Copy link
Contributor Author

nreese commented Oct 1, 2020

@elasticmachine merge upstream

@nreese nreese removed Feature:Embedding Embedding content via iFrame Team:Fleet Team label for Observability Data Collection Fleet team labels Oct 1, 2020
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

async chunks size

id before after diff
maps 3.3MB 3.3MB +2.5KB

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@nreese nreese merged commit 6c015cf into elastic:master Oct 2, 2020
nreese added a commit to nreese/kibana that referenced this pull request Oct 2, 2020
@nreese @elasticmachine
Convert VectorLayer to typescript (elastic#78490)
b971e73 
* [maps] convert VectorLayer to TS

* more tslint fixes

* clean up

* more tslint fixes

* more tslint fixes

* remove unneeded casts

* remove unneeded VectorStyle casts

* revert changes to layer.getQuery

* fix

* update tile layer constructor

* review feedback

Co-authored-by: Elastic Machine <[email protected]>
@nreese nreese mentioned this pull request Oct 2, 2020
Merged
nreese added a commit that referenced this pull request Oct 2, 2020
@nreese @elasticmachine
Convert VectorLayer to typescript (#78490) (#79239)
eaec9da 
* [maps] convert VectorLayer to TS

* more tslint fixes

* clean up

* more tslint fixes

* more tslint fixes

* remove unneeded casts

* remove unneeded VectorStyle casts

* revert changes to layer.getQuery

* fix

* update tile layer constructor

* review feedback

Co-authored-by: Elastic Machine <[email protected]>

Co-authored-by: Elastic Machine <[email protected]>
@thomasneirynck thomasneirynck mentioned this pull request Oct 19, 2020
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thomasneirynck thomasneirynck thomasneirynck approved these changes

Assignees
No one assigned
Labels
chore [Deprecated-Use Team:Presentation]Team:Geo Former Team Label for Geo Team. Now use Team:Presentation release_note:skip Skip the PR/issue when compiling release notes v7.10.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nreese @elasticmachine @kibanamachine @thomasneirynck