Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Mappings editor] Remove boost parameter #78331

Closed
wants to merge 3 commits into from
Closed

[Mappings editor] Remove boost parameter #78331

wants to merge 3 commits into from

Conversation

alisonelizabeth
Copy link
Contributor

Fixes #78293

This PR removes usage of the boost parameter from the mappings editor, as it will be deprecated in 8.0.

Note: This change will not be backported to 7.x.

@alisonelizabeth alisonelizabeth added Feature:Index Management Index and index templates UI v8.0.0 Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more release_note:skip Skip the PR/issue when compiling release notes Feature:Mappings Editor Index mappings editor UI labels Sep 23, 2020
alisonelizabeth
alisonelizabeth commented Sep 23, 2020
View reviewed changes
...tion/components/mappings_editor/components/document_fields/fields/field_types/shape_type.tsx
@@ -22,7 +22,6 @@ const getDefaultToggleValue = (param: ParameterName, field: FieldType): boolean

switch (param) {
// Switches that don't map to a boolean in the mappings
case 'boost':
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AFAICT this was a copy/paste mistake and is not being used in the shape type

@alisonelizabeth alisonelizabeth force-pushed the mappings_editor/deprecate_boost branch from 01aa9d2 to 1d84c7e Compare September 23, 2020 18:31
@alisonelizabeth alisonelizabeth marked this pull request as ready for review September 23, 2020 20:06
@alisonelizabeth alisonelizabeth requested a review from a team as a code owner September 23, 2020 20:06
@elasticmachine
Copy link
Contributor

Pinging @elastic/es-ui (Team:Elasticsearch UI)

@alisonelizabeth
Copy link
Contributor Author

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@sebelga sebelga mentioned this pull request Sep 30, 2020
Closed
@alisonelizabeth alisonelizabeth mentioned this pull request Oct 2, 2020
Closed
@cjcenizal cjcenizal mentioned this pull request Mar 29, 2021
Closed
@cjcenizal
Copy link
Contributor

When we merge this, should we remove the doc link to mapping-boost.html in the documentation service? See #95686 for a reference.

@alisonelizabeth
Copy link
Contributor Author

Closing this PR as it is quite old. The code should be updated to include conditional version logic for code alignment purposes. See #78923.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sebelga sebelga Awaiting requested review from sebelga

Assignees
No one assigned
Labels
Feature:Index Management Index and index templates UI Feature:Mappings Editor Index mappings editor UI release_note:skip Skip the PR/issue when compiling release notes Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Mappings editor] Remove boost parameter from field types
4 participants
@alisonelizabeth @elasticmachine @kibanamachine @cjcenizal