-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[7.10][Telemetry] Update data collection panel to show example security event. #78262
Conversation
…78134) Adds a tab in the _Edit Alert_ flyout which allows the user to _test_ their connector by executing it using an example action. The execution relies on the connector being updated, so is only enabled when there are no saved changes in the Connector form itself.
…#78078) * [Security Solution][Resolver] Show all event counts Co-authored-by: Elastic Machine <[email protected]>
* Adding bulk upgrade api * Addressing comments * Removing todo * Changing body field * Adding helper for getting the bulk install route * Adding request spec * Pulling in Johns changes * Removing test for same package upgraded multiple times * Pulling in John's error handling changes * Fixing type error
This is a re-do of PR #74063, which was merged to the wrong branch Co-authored-by: Nimex94 <[email protected]>
…prefer directly mounting (#78167) (#78204) * Remove HttpProvider in favor of mounting HttpLogic directly w/ props - removes need for initializeHttp call - ensures http value is loaded into HttpLogic as soon as possible / should never load in as null, reducing # of rerenders/checks see: https://kea.js.org/docs/guide/advanced#mounting-and-unmounting * Update simplest components using http for sendTelemetry * Update simplest tests for components using HttpLogic + default Kea mocks - Kea mock import should now contain mock default values which can be overridden * Update moderately complex tests using HttpLogic send_telemetry: - refactor to use shallow (w/ useEffect mocked) vs mount - check mockHttpValues directly engine_table: - refactor to use mount w/ an I18nProvider rather than mountWithContext helper (which we'll likely need to overhaul in the future) - assert mockHttpValues directly * Update EngineOverview to HttpLogic + refactors EngineOverview: - Change use of FormattedMessage to i18n.translate (simpler, no provider required) Tests: - Create mock values/actions for FlashMessages, since EngineOverview calls it - Create combined mockAllValues obj for easier overriding - Create setMockValues helper for easier test overriding (credit to @scottybollinger for the idea!) - Update engine_overview tests to setMockValues instead of passing context to mountWithAsyncContext - Fix mountWithAsyncContext to accept an undefined obj * Remove http from KibanaContext - it should now only live in HttpLogic 🔥 * Remove FlashMessagesProvider in favor of mounting logic directly w/ props - send history as prop - refactor out now-unnecessary listenToHistory (we can just do it directly in afterMount without worrying about duplicate react rerenders) - add mount helper Tests: - refactor history.listen mock to mockHistory (so that set_message_helpers can use it as well) - use mountFlashMessagesLogic + create an even shorter mount() helper (credit to @JasonStoltz for the idea!) - refactor out DEFAULT_VALUES since we're not really using it anywhere else in the file, and it's not super applicable to this store - update history listener tests to account for logic occurring immediately on mount
…r Calendars and Filter Lists (#77566) (#78198) Co-authored-by: Elastic Machine <[email protected]> Co-authored-by: Elastic Machine <[email protected]>
Co-authored-by: Elastic Machine <[email protected]> Co-authored-by: Elastic Machine <[email protected]>
* [Reporting] Clean Up TypeScript Definitions (#76566) * [Reporting] Simplify Export Type Definitions, use defaults for generics, refactor * ReportApiJSON interface for common * rename JobSummary to JobStatusBucket for clarity * revert unneeded create mock changes * clean up the diff * revert changes to worker.js * rewrite comment * rename type to jobtype in JobStatusBucket * allow type inference * JobSummarySet * remove odd comment * Reflect that browser timezone may be undefined in the BaseParams * comment about optional browserTimezone * revert unecessary es archive change Co-authored-by: Elastic Machine <[email protected]> * fix ts Co-authored-by: Elastic Machine <[email protected]>
…78197) * Rollback the logger & try/catch changes from #77640 (#77806) * Doing a try/catch and re-throwing doesn't gain us anything. We already catching the error in the route handler * We have logging for the issue in the existing handler. We also don't pass a logging context to functions * Add missing import
…78240) # Conflicts: # src/dev/build/tasks/os_packages/docker_generator/resources/bin/kibana-docker
* remove ALL the things. * adapt some types and tests * restore ensureValidConfiguration * fix legacy service tests * adapt uiRender mixin * remove legacy types * update generated doc * restore legacy plugin schema * update generated doc * remove remaining code of x-pack/legacy * adapt imports due to merge * cleanup CODEOWNERS * cleanup gitignore & i18nrc * cleanup tsconfig.json * remove unused i18n keys * add back `"legacy/plugins/**/*",` to tsconfig until legacy space plugin is deleted * fix create_jest_config * remove references from eslintrc * more eslint cleanup * remove `x-pack/index.js` * fix xpack gulp scripts * fix bug with default + named imports from boom * remove rules from eslintrc * remove LegacyInternals * review comments * update generated doc * cleanup legacy metadatas * revert changes to eslintrc * update generated doc # Conflicts: # .github/CODEOWNERS # x-pack/.i18nrc.json # x-pack/dev-tools/jest/create_jest_config.js # x-pack/legacy/plugins/xpack_main/index.js # x-pack/legacy/server/lib/constants/index.ts # x-pack/legacy/server/lib/key_case_converter.js # x-pack/legacy/server/lib/watch_status_and_license_to_initialize.js
…8102) (#78857) * wip * advanced settings * removed unused vars * unused vars * fix label issue and ignore duplicate id issue * fixing advanced management * fixing jest tests * i18n translations * i18n translations * fixed jest tests * addressed review comments * addressed review comments * addressed review comments * reverted the snapshot Co-authored-by: Michail Yasonik <[email protected]> Co-authored-by: Elastic Machine <[email protected]> Co-authored-by: Michail Yasonik <[email protected]> Co-authored-by: Elastic Machine <[email protected]>
* Make Field a React.lazy export * Fix broken types Co-authored-by: Elastic Machine <[email protected]> Co-authored-by: Elastic Machine <[email protected]>
… main app + share its store (#78691) (#78866) * [Setup] Refactor renderApp tests - This is anticipation of upcoming renderHeaderActions changes which will require these helpers (particularly the unmount portion, for some reason renderHeaderAction tests fail if apps are not unmounted properly) - Add mount/unmount helper (but leave first test the same so that devs can see the normal/expected usage) - Add missing EnterpriseSearch app test - Add mockContainer var for brevity, pull out MockApp in anticipation of future usage * Store renderHeaderActions in KibanaLogic - a light wrapper/helper around params.setHeaderActionMenu + update renderHeaderActions - move to main renderApp block to reflect that its relationship with renderApp ('child'/should be called within renderApp/shares dependencies). * Update WorkplaceSearch to render its header actions from app, not plugin.ts * Update WorkplaceSearch tests (+ bonus refactor) - We need to update WS tests to setMockValues so that it doesn't override the renderHeaderActions mock + bonus - add setMockActions as well because since we're already here + bonus - update App Search index tests as well to match + ?? - for some reason tests were failing beceause react router wasn't mocked properly - requireActual seems to fix that * 🔥 Remove temporary externalUrl workaround - set in 9d993d8 - WorkplaceSearchHeaderActions should now still have the correct URL - and also now be able to access all Kea logic set up by the main app :)
Co-authored-by: Elastic Machine <[email protected]> Co-authored-by: Elastic Machine <[email protected]>
Co-authored-by: Elastic Machine <[email protected]> Co-authored-by: Elastic Machine <[email protected]>
Add OpenTelemetry agent names and and icon. OpenTelemetry services will have the same icon as the corresponding APM services. Services that report "otlp" as their agent name use the OpenTelemetry icon. The OpenTelemetry agents are now collected in the data telemetry along with the other agent names. Change "ratio" in the telemetry to a float.
@elasticmachine merge upstream |
…emetry_management_section.tsx Co-authored-by: Christiane (Tina) Heiligers <[email protected]>
I spent an hour looking into this. It is because the Telemetry Management Section registers itself as a footer to the Advanced Settings plugin: kibana/src/plugins/telemetry_management_section/public/plugin.tsx Lines 41 to 51 in 80c004c
I had my findings confirmed by a Kibana Arch team member. They described the change as a non-negligible amount of coding. Because of not wanting to hold this change up it can be addressed in another PR - either by me or you. Regardless, this was a great find by the design team! |
💔 Build Failed
Failed CI StepsTest FailuresJest Tests.src/plugins/telemetry_management_section/public/components.OptInDetailsComponent security flyout renders as expectedStandard Out
Stack Trace
Metrics [docs]
History
To update your PR or re-run it, just comment with: |
I think this branch was originally created from |
Yeah, agreed @afharo. This branch is toast. I will re-open a fresh PR 👍 |
Summary
Resolves #68942
Related to #77200
Related to elastic/protections-team#172 (Data Engineering)
This PR adds a fly-out with an example of a security event collected from Elastic Endpoint when enabled.
Checklist
Delete any items that are not applicable to this PR.
For maintainers