Accessibility - Dashboard Edit Panel tests #78181
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rashmivkulkarni
added
Feature:Dashboard
|
Pinging @elastic/kibana-qa (Team:QA) |
|
Pinging @elastic/kibana-app (Team:KibanaApp) |
💚 Build SucceededBuild metrics@kbn/optimizer bundle module count
async chunks size
miscellaneous assets size
page load bundle size
To update your PR or re-run it, just comment with: |
rashmivkulkarni
requested review from
bhavyarm and
flash1293
and removed request for
bhavyarm
myasonik
approved these changes
Sep 22, 2020
|
Friendly reminder: Looks like this PR hasn’t been backported yet. |
kibanamachine
added
the
backport missing
|
Friendly reminder: Looks like this PR hasn’t been backported yet. |
rashmivkulkarni
added a commit
to rashmivkulkarni/kibana
that referenced
this pull request
Sep 25, 2020
* accessibility tests for dashboard panel * added back the skipped test as it is still required to pass through th ea11ySnapshot * wip dashboard panel tests * wip- accessibility * wip -accessibility * wip accessibility * accessibility tests for dashboard edit panel * accessibility tests * removed the unused variables * dashboard_edit_panel tests * added a comment Co-authored-by: Elastic Machine <[email protected]>
kibanamachine
removed
the
backport missing
rashmivkulkarni
added a commit
that referenced
this pull request
Sep 26, 2020
* accessibility tests for dashboard panel * added back the skipped test as it is still required to pass through th ea11ySnapshot * wip dashboard panel tests * wip- accessibility * wip -accessibility * wip accessibility * accessibility tests for dashboard edit panel * accessibility tests * removed the unused variables * dashboard_edit_panel tests * added a comment Co-authored-by: Elastic Machine <[email protected]> Co-authored-by: Elastic Machine <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref Meta issue: #51456
Fixes #60766