bump query-string version to remove manual type definitions #78143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mshustov
added
Team:Core
mshustov
commented
Sep 22, 2020
| { sort: false, encode: false } | ||
| ); | ||
| const newValue = | ||
| typeof urlState === 'undefined' |
There was a problem hiding this comment.
stringify types do not accept undefined
mshustov
commented
Sep 22, 2020
| expect(addEmbeddableToDashboardUrl(url, id, 'visualization')).toEqual( | ||
| `/pep/app/dashboards#/view/9b780cd0-3dd3-11e8-b2b9-5d5dc1715159?_a=%28description%3A%27%27%2Cfilters%3A%21%28%29%29&_g=%28refreshInterval%3A%28pause%3A%21t%2Cvalue%3A0%29%2Ctime%3A%28from%3Anow-15m%2Cto%3Anow%29%29&addEmbeddableId=${id}&addEmbeddableType=visualization` | ||
| expect(addEmbeddableToDashboardUrl(url, id, 'visualization')).toBe( | ||
| '/pep/app/dashboards?addEmbeddableId=123eb456cd&addEmbeddableType=visualization#%2Fview%2F9b780cd0-3dd3-11e8-b2b9-5d5dc1715159%3F_g%3D%28refreshInterval%3A%28pause%3A%21t%2Cvalue%3A0%29%2Ctime%3A%28from%3Anow-15m%2Cto%3Anow%29%29%26_a%3D%28description%3A%27%27%2Cfilters%3A%21%28%29%29' |
There was a problem hiding this comment.
fragment after query seems to be the correct order https://tools.ietf.org/html/rfc3986#page-16
mshustov
commented
Sep 22, 2020
| @@ -34,12 +34,14 @@ export function addEmbeddableToDashboardUrl( | |||
| embeddableId: string, | |||
| embeddableType: string | |||
| ) { | |||
| const { url, query } = parseUrl(dashboardUrl); | |||
| const { url, query, fragmentIdentifier } = parseUrl(dashboardUrl, { | |||
There was a problem hiding this comment.
parseUrl seems to be broken in an intermediate release and fixed in 6.13.0 sindresorhus/query-string#222
|
Pinging @elastic/kibana-platform (Team:Platform) |
botelastic
bot
added
the
Team:Uptime - DEPRECATED
|
Pinging @elastic/uptime (Team:uptime) |
pgayvallet
approved these changes
Sep 23, 2020
1 task
spong
approved these changes
Sep 23, 2020
flash1293
reviewed
Sep 24, 2020
| expect(addEmbeddableToDashboardUrl(url, id, 'visualization')).toEqual( | ||
| `/pep/app/dashboards#/view/9b780cd0-3dd3-11e8-b2b9-5d5dc1715159?_a=%28description%3A%27%27%2Cfilters%3A%21%28%29%29&_g=%28refreshInterval%3A%28pause%3A%21t%2Cvalue%3A0%29%2Ctime%3A%28from%3Anow-15m%2Cto%3Anow%29%29&addEmbeddableId=${id}&addEmbeddableType=visualization` | ||
| expect(addEmbeddableToDashboardUrl(url, id, 'visualization')).toBe( | ||
| '/pep/app/dashboards?addEmbeddableId=123eb456cd&addEmbeddableType=visualization#%2Fview%2F9b780cd0-3dd3-11e8-b2b9-5d5dc1715159%3F_g%3D%28refreshInterval%3A%28pause%3A%21t%2Cvalue%3A0%29%2Ctime%3A%28from%3Anow-15m%2Cto%3Anow%29%29%26_a%3D%28description%3A%27%27%2Cfilters%3A%21%28%29%29' |
There was a problem hiding this comment.
@restrry You are correct query comes before fragment in "regular" URLs, but in angular it's the other way around when using hash routing:
However I'm not sure whether we still need this - it seems like we switched to transport this information using the history state and this is just a leftover. @ThomThomson @majagrubic can you please verify
There was a problem hiding this comment.
Thanks for bringing this up. AFAIK, this is not used anymore and should be safe to remove entirely.
There was a problem hiding this comment.
@majagrubic is it okay if I merge this PR and you remove it in a follow-up? I still need an approval
rudolf
approved these changes
Sep 24, 2020
majagrubic
approved these changes
Sep 24, 2020
💚 Build SucceededMetrics [docs]@kbn/optimizer bundle module count
async chunks size
page load bundle size
distributable file count
History
To update your PR or re-run it, just comment with: |
mshustov
added a commit
to mshustov/kibana
that referenced
this pull request
Sep 24, 2020
…78143) * bump query-string version to remove manual type definitions * remove manual type declaration * fix cypress tests * add ) # Conflicts: # x-pack/plugins/security_solution/cypress/integration/ml_conditional_links.spec.ts
mshustov
added a commit
that referenced
this pull request
Sep 24, 2020
…78441) * bump query-string version to remove manual type definitions * remove manual type declaration * fix cypress tests * add ) # Conflicts: # x-pack/plugins/security_solution/cypress/integration/ml_conditional_links.spec.ts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Reverts #59633 since we do not support IE 11 anymore. https://github.com/sindresorhus/query-string/releases/tag/v6.0.0
Required to remove manually maintained type definitions that we have to include in every ts project.
Checklist
Delete any items that are not applicable to this PR.
For maintainers