Prevent pageload on drilldown in tsvb #78005
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flash1293
added
the
Team:Visualizations
|
Pinging @elastic/kibana-app (Team:KibanaApp) |
|
@elasticmachine merge upstream |
stratoula
approved these changes
Sep 24, 2020
💚 Build SucceededMetrics [docs]async chunks size
History
To update your PR or re-run it, just comment with: |
flash1293
added a commit
to flash1293/kibana
that referenced
this pull request
Sep 24, 2020
flash1293
added a commit
that referenced
this pull request
Sep 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #77733
TSVB has its own notion of drilldown urls (called "Item URL") in the UI in table and top n visualizations. These are currently triggering a full page load in some scenarios because they are not using
core.application.navigateToUrl.This PR fixes this by adding a
RedirectAppLinksboundary for the table and callingnavigateToUrldirectly for the top n visualization.The problem described in the linked issue is not 100% fixed though because the logic of
navigateToUrlis not resolving../paths correctly, thinking e.g../app/discovernot being an app URL (#78007)