Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed delete confirmation timeout to avoid flaky failing because deletion to be a little slower on CI #77963

Merged
merged 3 commits into from
Sep 23, 2020
Merged

Removed delete confirmation timeout to avoid flaky failing because deletion to be a little slower on CI #77963

merged 3 commits into from
Sep 23, 2020

Conversation

YulNaumenko
Copy link
Contributor

Resolve #77401

@YulNaumenko YulNaumenko added Feature:Alerting v8.0.0 release_note:skip Skip the PR/issue when compiling release notes Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) v7.10.0 Project:Alerting labels Sep 18, 2020
@YulNaumenko YulNaumenko requested a review from a team as a code owner September 18, 2020 22:49
@YulNaumenko YulNaumenko self-assigned this Sep 18, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-alerting-services (Team:Alerting Services)

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Build metrics

async chunks size

id value diff baseline
triggers_actions_ui 963.9KB +2.4KB 961.5KB

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

pmuellr
pmuellr approved these changes Sep 22, 2020
View reviewed changes
Copy link
Member

@pmuellr pmuellr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code LGTM; did this get run through the flaky test runner yet?

@YulNaumenko
Copy link
Contributor Author

code LGTM; did this get run through the flaky test runner yet?

@pmuellr , Yes this is the results:
img

gmmorris
gmmorris approved these changes Sep 23, 2020
View reviewed changes
Copy link
Contributor

@gmmorris gmmorris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

x-pack/test/functional_with_es_ssl/apps/triggers_actions_ui/alerts.ts
Comment on lines -388 to +392
await testSubjects.missingOrFail('deleteIdsConfirmation', { timeout: 5000 });
await testSubjects.missingOrFail('deleteIdsConfirmation');

await pageObjects.common.closeToast();
await retry.try(async () => {
const toastTitle = await pageObjects.common.closeToast();
expect(toastTitle).to.eql('Deleted 10 alerts');
});
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems much more reliable!
Good change 👍

@YulNaumenko YulNaumenko merged commit 12153a4 into elastic:master Sep 23, 2020
@YulNaumenko YulNaumenko mentioned this pull request Sep 23, 2020
Merged
YulNaumenko added a commit to YulNaumenko/kibana that referenced this pull request Sep 23, 2020
@YulNaumenko
Removed delete confirmation timeout to avoid flaky failing because de…
6e44149 
…letion to be a little slower on CI (elastic#77963)

* Removed delete confirmation timeout to avoid flaky failing because deletion to be a little slower on CI

* Changed delete flow to close confim dialog immediately and set data to the loading state
YulNaumenko added a commit that referenced this pull request Sep 24, 2020
@YulNaumenko
Removed delete confirmation timeout to avoid flaky failing because de…
0d39609 
…letion to be a little slower on CI (#77963) (#78320)

* Removed delete confirmation timeout to avoid flaky failing because deletion to be a little slower on CI

* Changed delete flow to close confim dialog immediately and set data to the loading state
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gmmorris gmmorris gmmorris approved these changes

@pmuellr pmuellr pmuellr approved these changes

Assignees

@YulNaumenko YulNaumenko

Labels
Feature:Alerting Project:Alerting release_note:skip Skip the PR/issue when compiling release notes Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) v7.10.0 v8.0.0
Projects
None yet
Milestone
No milestone
5 participants
@YulNaumenko @elasticmachine @kibanamachine @pmuellr @gmmorris