Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[7.x] [APM] Remove useLocation and some minor route improvements (#76343) #77476

Merged
merged 1 commit into from
Sep 15, 2020

Conversation

smith
Copy link
Contributor

@smith smith commented Sep 15, 2020

Backports the following commits to 7.x:

…6343)

* [APM] Remove useLocation and some minor route improvements

* Replace `useLocation` and our `LocationContext` with `useLocation` from React Router. We can do this since we're now using the platform history, added in elastic#76287.
* Pass in `RouteComponentProps` where appropriate to routes to use `history` and `location`.

This is in the service of elastic#51963, but doesn't do anything with `useUrlParams` or any of the other changes specified in that issue.
@smith smith added the backport label Sep 15, 2020
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Build metrics

@kbn/optimizer bundle module count

id value diff baseline
apm 1255 -2 1257

async chunks size

id value diff baseline
apm 5.0MB -2.6KB 5.0MB

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@smith smith merged commit 67c11fc into elastic:7.x Sep 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants