-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Detections][EQL] EQL rule execution in detection engine #77419
Merged
Merged
Changes from all commits
Commits
Show all changes
31 commits
Select commit
Hold shift + click to select a range
6cf620f
First draft of EQL rules in detection engine
marshallmain 82ae0c2
Reorganize functions to separate files
marshallmain 9b450bf
Start adding eventCategoryOverride option for EQL rules
marshallmain d3fce8a
Add building block alerts for each event within sequence
marshallmain ad9fe1b
Merge branch 'master' into eql-rules
marshallmain 922a21e
Use eql instead of eql_query for rule type
marshallmain ecedb3f
Remove unused imports
marshallmain 3e45bc8
Fix tests
marshallmain 4faa592
Add basic tests for buildEqlSearchRequest
marshallmain f9e26b0
Add rulesSchema tests for eql
marshallmain 3fd19f0
Add buildSignalFromSequence test
marshallmain bcdde62
Add threat rule fields to buildRuleWithoutOverrides
marshallmain 162256a
Fix buildSignalFromSequence typecheck error
marshallmain 3f89fb9
Add more tests
marshallmain 8b00aa7
Add tests for wrapBuildingBlock and generateSignalId
marshallmain 2657188
Merge branch 'master' into eql-rules
marshallmain 1011f07
Use isEqlRule function and fix import error
marshallmain cf0f9fb
delete frank
marshallmain 1d680a7
Move sequence interface to types.ts
marshallmain 5ebe577
Fix import
marshallmain f445d87
Remove EQL execution placeholder, add back language to eql rule type
marshallmain 1c5afd9
allow no indices for eql search
marshallmain 506a3d6
Fix unit tests for language update
marshallmain aacc605
Fix buildEqlSearchRequest tests
marshallmain 19cf9e2
Replace signal.child with signal.group
marshallmain b42cf73
remove unused import
marshallmain 1942bf9
Move sequence signal group building to separate testable function
marshallmain 22383a9
Merge branch 'master' into eql-rules
elasticmachine 8142b11
Merge branch 'master' into eql-rules
marshallmain 45ecb42
Unbork the merge conflict resolution
marshallmain 9a6e908
Merge branch 'master' into eql-rules
elasticmachine File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Another way I have seen these written as has been like so:
No changes asked, just pointing out another way if you wanted to avoid the delete and the assignments.