Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix APM e2e tests #77415

Closed
wants to merge 2 commits into from
Closed

Fix APM e2e tests #77415

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
543e00f
Fix APM e2e tests
smith Sep 14, 2020
439ec17
Remove remaining hashes
smith Sep 14, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion x-pack/plugins/apm/e2e/cypress/integration/apm.feature
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
KibanaFeature: APM
Feature: APM

Scenario: Transaction duration charts
Given a user browses the APM UI application
Expand Down
2 changes: 1 addition & 1 deletion x-pack/plugins/apm/e2e/cypress/support/step_definitions/apm.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ export const DEFAULT_TIMEOUT = 60 * 1000;

Given(`a user browses the APM UI application`, () => {
// open service overview page
loginAndWaitForPage(`/app/apm#/services`, {
loginAndWaitForPage(`/app/apm/services`, {
from: '2020-06-01T14:59:32.686Z',
to: '2020-06-16T16:59:36.219Z',
});
Expand Down
2 changes: 1 addition & 1 deletion x-pack/plugins/apm/e2e/cypress/support/step_definitions/rum/rum_dashboard.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ Given(`a user browses the APM UI application for RUM Data`, () => {
// open service overview page
const RANGE_FROM = 'now-24h';
const RANGE_TO = 'now';
loginAndWaitForPage(`/app/apm#/rum-preview`, {
loginAndWaitForPage(`/app/apm/rum-preview`, {
from: RANGE_FROM,
to: RANGE_TO,
});
Expand Down
6 changes: 3 additions & 3 deletions x-pack/plugins/apm/public/services/rest/apm_overview_fetchers.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ describe('Observability dashboard data', () => {
);
const response = await fetchOverviewPageData(params);
expect(response).toEqual({
appLink: '/app/apm#/services?rangeFrom=now-15m&rangeTo=now',
appLink: '/app/apm/services?rangeFrom=now-15m&rangeTo=now',
stats: {
services: {
type: 'number',
Expand Down Expand Up @@ -82,7 +82,7 @@ describe('Observability dashboard data', () => {
);
const response = await fetchOverviewPageData(params);
expect(response).toEqual({
appLink: '/app/apm#/services?rangeFrom=now-15m&rangeTo=now',
appLink: '/app/apm/services?rangeFrom=now-15m&rangeTo=now',
stats: {
services: {
type: 'number',
Expand All @@ -109,7 +109,7 @@ describe('Observability dashboard data', () => {
);
const response = await fetchOverviewPageData(params);
expect(response).toEqual({
appLink: '/app/apm#/services?rangeFrom=now-15m&rangeTo=now',
appLink: '/app/apm/services?rangeFrom=now-15m&rangeTo=now',
stats: {
services: {
type: 'number',
Expand Down
2 changes: 1 addition & 1 deletion x-pack/plugins/apm/public/services/rest/apm_overview_fetchers.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ export const fetchOverviewPageData = async ({
const { serviceCount, transactionCoordinates } = data;

return {
appLink: `/app/apm#/services?rangeFrom=${relativeTime.start}&rangeTo=${relativeTime.end}`,
appLink: `/app/apm/services?rangeFrom=${relativeTime.start}&rangeTo=${relativeTime.end}`,
stats: {
services: {
type: 'number',
Expand Down