Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Functional] Fixes cloud failures on TSVB markdown #77158

Merged
merged 6 commits into from
Sep 15, 2020
Merged

[Functional] Fixes cloud failures on TSVB markdown #77158

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
8ab2860
[TSVB] Remove the char by char typing on markodown
stratoula Sep 10, 2020
c4ed226
Merge branch 'master' into tsvb-markdown-functional-failures
stratoula Sep 14, 2020
ba8d7d1
Merge branch 'master' into tsvb-markdown-functional-failures
stratoula Sep 15, 2020
c9a6b45
revert
stratoula Sep 15, 2020
a63d497
Add the markdown to be computed immediately and give some time to com…
stratoula Sep 15, 2020
dbab912
Add retry to locate TSVB tabs
stratoula Sep 15, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions test/functional/page_objects/visual_builder_page.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,10 @@ export function VisualBuilderPageProvider({ getService, getPageObjects }: FtrPro
}

public async checkTabIsLoaded(testSubj: string, name: string) {
const isPresent = await testSubjects.exists(testSubj, { timeout: 10000 });
let isPresent = false;
await retry.try(async () => {
isPresent = await testSubjects.exists(testSubj, { timeout: 20000 });
});
if (!isPresent) {
throw new Error(`TSVB ${name} tab is not loaded`);
}
Expand Down Expand Up @@ -130,8 +133,8 @@ export function VisualBuilderPageProvider({ getService, getPageObjects }: FtrPro
public async enterMarkdown(markdown: string) {
const input = await find.byCssSelector('.tvbMarkdownEditor__editor textarea');
await this.clearMarkdown();
await input.type(markdown, { charByChar: true });
await PageObjects.visChart.waitForVisualizationRenderingStabilized();
await input.type(markdown);
await PageObjects.common.sleep(3000);
}

public async clearMarkdown() {
Expand Down