-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Monitoring] Prevent edit/create for Stack Monitoring alerts in Alerts Management #77097
Merged
chrisronline
merged 1 commit into
elastic:master
from
chrisronline:monitoring/alerts_edit
Sep 10, 2020
Merged
[Monitoring] Prevent edit/create for Stack Monitoring alerts in Alerts Management #77097
chrisronline
merged 1 commit into
elastic:master
from
chrisronline:monitoring/alerts_edit
Sep 10, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrisronline
added
review
release_note:fix
Team:Monitoring
Stack Monitoring team
v8.0.0
v7.10.0
v7.9.2
labels
Sep 9, 2020
Pinging @elastic/stack-monitoring (Team:Monitoring) |
igoristic
approved these changes
Sep 10, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
This was referenced Sep 10, 2020
chrisronline
added a commit
to chrisronline/kibana
that referenced
this pull request
Sep 10, 2020
chrisronline
added a commit
that referenced
this pull request
Sep 10, 2020
chrisronline
added a commit
that referenced
this pull request
Sep 10, 2020
23 tasks
24 tasks
24 tasks
35 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #75414
This prevents the creation and editing of Stack Monitoring-specific alerts in the Alerts Management UI since the creation creates a broken UX. The alerting team will follow up in a future version with support for editing but not creation and at that point, we can revert this.