Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Lens] Update grouping editor to indicate the expected result of a grouping change #76904

Merged
merged 1 commit into from
Sep 8, 2020
Merged

[Lens] Update grouping editor to indicate the expected result of a grouping change #76904

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions x-pack/plugins/lens/public/indexpattern_datasource/dimension_panel/bucket_nesting_editor.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,8 @@ export function BucketNestingEditor({
values: { field: fieldName },
})
: i18n.translate('xpack.lens.indexPattern.groupingOverallDateHistogram', {
defaultMessage: 'Dates overall',
defaultMessage: 'Top values for each {field}',
values: { field: fieldName },
})
}
checked={!prevColumn}
Expand All @@ -96,7 +97,7 @@ export function BucketNestingEditor({
values: { target: target.fieldName },
})
: i18n.translate('xpack.lens.indexPattern.groupingSecondDateHistogram', {
defaultMessage: 'Dates for each {target}',
defaultMessage: 'Overall top {target}',
values: { target: target.fieldName },
})
}
Expand Down
2 changes: 0 additions & 2 deletions x-pack/plugins/translations/translations/ja-JP.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9643,9 +9643,7 @@
"xpack.lens.indexPattern.fieldTopValuesLabel": "トップの値",
"xpack.lens.indexPattern.groupByDropdown": "グループ分けの条件",
"xpack.lens.indexPattern.groupingControlLabel": "グループ分け",
"xpack.lens.indexPattern.groupingOverallDateHistogram": "全体の日付",
"xpack.lens.indexPattern.groupingOverallTerms": "全体のトップ {field}",
"xpack.lens.indexPattern.groupingSecondDateHistogram": "各 {target} の日付",
"xpack.lens.indexPattern.groupingSecondTerms": "各 {target} のトップの値",
"xpack.lens.indexPattern.indexPatternLoadError": "インデックスパターンの読み込み中にエラーが発生",
"xpack.lens.indexPattern.invalidInterval": "無効な間隔値",
Expand Down
2 changes: 0 additions & 2 deletions x-pack/plugins/translations/translations/zh-CN.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9649,9 +9649,7 @@
"xpack.lens.indexPattern.fieldTopValuesLabel": "排名最前值",
"xpack.lens.indexPattern.groupByDropdown": "分组依据",
"xpack.lens.indexPattern.groupingControlLabel": "分组",
"xpack.lens.indexPattern.groupingOverallDateHistogram": "日期 - 总体",
"xpack.lens.indexPattern.groupingOverallTerms": "总体排名最前 {field}",
"xpack.lens.indexPattern.groupingSecondDateHistogram": "每个 {target} 的日期",
"xpack.lens.indexPattern.groupingSecondTerms": "每个 {target} 的排名最前值",
"xpack.lens.indexPattern.indexPatternLoadError": "加载索引模式时出错",
"xpack.lens.indexPattern.invalidInterval": "时间间隔值无效",
Expand Down