Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[APM-UI][E2E] filter PRs from the apm-ui GH team #76764

Merged
merged 2 commits into from
Sep 14, 2020

Conversation

v1v
Copy link
Member

@v1v v1v commented Sep 4, 2020

Summary

Filter when to run the builds for the APM-UI e2e tests which are based on the below reasons:

  • On a PRs when:
    • There are changes related to the APM UI project
      • only when the owners of those changes are members of the apm-ui team (new filter)
  • On merges to branches when:
    • There are changes related to the APM UI project
  • FORCE parameter is set to true.

For maintainers

Further details

It's required to release a new version for the apm-pipeline-library.

@v1v v1v added the Team:APM - DEPRECATED Use Team:obs-ux-infra_services. label Sep 4, 2020
@v1v v1v self-assigned this Sep 4, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/apm-ui (Team:apm)

apm_updated = isGitRegionMatch(patterns: [ "^x-pack/plugins/apm/.*" ])
}
if (isPR()) {
def isMember = isMemberOf(user: env.CHANGE_AUTHOR, team: 'apm-ui')
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CHANGE_AUTHOR
For a multibranch project corresponding to some kind of change request, this will be set to the username of the author of the proposed change, if supported; else unset.

@v1v v1v added backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes labels Sep 14, 2020
@v1v
Copy link
Member Author

v1v commented Sep 14, 2020

@elasticmachine merge upstream

@v1v v1v added the v8.0.0 label Sep 14, 2020
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Build metrics

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@v1v v1v merged commit 98c9b18 into elastic:master Sep 14, 2020
@v1v v1v deleted the feature/validate-pr-owner-member-of-apm-ui branch September 14, 2020 10:11
@v1v v1v removed the backport:skip This commit does not require backporting label Sep 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release_note:skip Skip the PR/issue when compiling release notes Team:APM - DEPRECATED Use Team:obs-ux-infra_services. v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants