[Snapshot & Restore] Decode URIs and fix editing of a policy #76278
Conversation
jloleysens
added
release_note:fix
v8.0.0
Team:Kibana Management
|
Pinging @elastic/es-ui (Team:Elasticsearch UI) |
|
@elasticmachine merge upstream |
There was a problem hiding this comment.
Thanks for fixing these bugs @jloleysens!
The change does indeed fix the problem of using : in the name, however, there is still an error if using a %. You can take a look in the component templates code for what I did to address this. Re: #69732 (comment).
I also noticed both the summary tab in the review step and the details panel sometimes has no value under the Data streams and indices section when all indices/data streams are selected.
|
@alisonelizabeth Thanks for the review! It looks like there was an issue with how serialisation of policy config was being done and that was the issue that helped me to uncover the weird validation issue too. I've addressed your feedback, would you mind taking another look? |
| export const attemptToURIDecode = (value: string) => { | ||
| let result: string; | ||
| try { | ||
| result = decodeURIComponent(value); |
There was a problem hiding this comment.
I think you might also have to try decodeURI. Otherwise, when doing a full page refresh with the details panel open, you might get a 404.
💚 Build SucceededBuild metrics@kbn/optimizer bundle module count
async chunks size
History
To update your PR or re-run it, just comment with: |
jloleysens
deleted the
snapshot-restore/fix-uri-encoding-and-policy-edit
branch
…#76278) * fix URI decoding and editing of a policy which backs up all indices * fix type issue * fix general use of encoding and update decode algo * fix serialisation of snapshots and added a test * Fix test description name * Update attempt_to_uri_decode.ts * catch errors from decoding in the already throwing code Co-authored-by: Elastic Machine <[email protected]>
…#76278) * fix URI decoding and editing of a policy which backs up all indices * fix type issue * fix general use of encoding and update decode algo * fix serialisation of snapshots and added a test * Fix test description name * Update attempt_to_uri_decode.ts * catch errors from decoding in the already throwing code Co-authored-by: Elastic Machine <[email protected]>
…#76320) * fix URI decoding and editing of a policy which backs up all indices * fix type issue * fix general use of encoding and update decode algo * fix serialisation of snapshots and added a test * Fix test description name * Update attempt_to_uri_decode.ts * catch errors from decoding in the already throwing code Co-authored-by: Elastic Machine <[email protected]> Co-authored-by: Elastic Machine <[email protected]>
…#76322) * fix URI decoding and editing of a policy which backs up all indices * fix type issue * fix general use of encoding and update decode algo * fix serialisation of snapshots and added a test * Fix test description name * Update attempt_to_uri_decode.ts * catch errors from decoding in the already throwing code Co-authored-by: Elastic Machine <[email protected]> Co-authored-by: Elastic Machine <[email protected]>
alisonelizabeth
added
the
Feature:Snapshot and Restore
Summary
Add logic for decoding snapshot policy, snapshot repository, snapshot and restore names.
Fix: #75951
Also discovered an issue when editing existing policies. The form will block (incorrectly) when editing a policy's name (or any other value) because the validation thinks that indices need to be set. This is a regression from the behaviour added here: #68078. The fix for now is to bypass this validation unless we are specifically editing index name values in the UI.
How to test decoding - after fix
yarn es snapshot -E path.repo=/tmp/es-snaps)How to test editing policy fix
This should be covered in the steps mentioned before if you repeated steps 3 and 4 for editing a snapshot policy after creating it. But to reiterate:
Release note
Fixed an issue in Snapshot and Restore UI where creating a policy, repository or snapshot with a special character, like a colon, in the name would result in a 404 when viewing details or editing any of the aforementioned.