Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert back ESO migration for alerting, added try/catch logic to avoid failing Kibana on start #76220

Merged
merged 9 commits into from
Sep 4, 2020
Merged

Revert back ESO migration for alerting, added try/catch logic to avoid failing Kibana on start #76220

merged 9 commits into from
Sep 4, 2020

Conversation

YulNaumenko
Copy link
Contributor

@YulNaumenko YulNaumenko commented Aug 28, 2020 •
edited
Loading

Resolve #74404

@YulNaumenko YulNaumenko added Feature:Alerting v8.0.0 release_note:skip Skip the PR/issue when compiling release notes Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) v7.10.0 labels Aug 28, 2020
@YulNaumenko YulNaumenko requested a review from a team as a code owner August 28, 2020 01:00
@YulNaumenko YulNaumenko self-assigned this Aug 28, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-alerting-services (Team:Alerting Services)

@YulNaumenko YulNaumenko linked an issue Aug 28, 2020 that may be closed by this pull request
[Alerting] Upgrade to 7.10 without migrating old alerts will result in broken alerts #74404
Closed
@mikecote mikecote self-requested a review August 31, 2020 15:44
@mikecote
Copy link
Contributor

I think the description should resolve #74404 and not #76061?

mikecote
mikecote reviewed Aug 31, 2020
View reviewed changes
Copy link
Contributor

@mikecote mikecote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few comments but heading in the right direction 👍

x-pack/plugins/alerts/server/saved_objects/migrations.ts Outdated Show resolved Hide resolved
x-pack/plugins/alerts/server/saved_objects/migrations.ts Outdated Show resolved Hide resolved
x-pack/plugins/alerts/server/saved_objects/migrations.ts Outdated Show resolved Hide resolved
@YulNaumenko
fixed due to comments
d9267db
@YulNaumenko
Merge remote-tracking branch 'upstream/master' into alerting-migratio…
99efa24 
…n-revert

# Please enter a commit message to explain why this merge is necessary,
# especially if it merges an updated upstream into a topic branch.
#
# Lines starting with '#' will be ignored, and an empty message aborts
# the commit.
@YulNaumenko YulNaumenko requested a review from mikecote September 1, 2020 21:18
mikecote
mikecote approved these changes Sep 3, 2020
View reviewed changes
Copy link
Contributor

@mikecote mikecote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM! 👍

x-pack/plugins/alerts/server/saved_objects/migrations.test.ts Show resolved Hide resolved
@YulNaumenko
Added migration failure unit test
6cca8ec
@YulNaumenko
Merge remote-tracking branch 'upstream/master' into alerting-migratio…
77c0b3a 
…n-revert

# Please enter a commit message to explain why this merge is necessary,
# especially if it merges an updated upstream into a topic branch.
#
# Lines starting with '#' will be ignored, and an empty message aborts
# the commit.
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Build metrics

distributable file count

id value diff baseline
total 45470 +1 45469

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@YulNaumenko YulNaumenko merged commit ef53372 into elastic:master Sep 4, 2020
YulNaumenko added a commit to YulNaumenko/kibana that referenced this pull request Sep 4, 2020
@YulNaumenko
Revert back ESO migration for alerting, added try/catch logic to avoi…
05fba9b 
…d failing Kibana on start (elastic#76220)

* Revert back ESO migration for alerting, added try/catch logic to avoid failing Kibana on start

* Revert back ESO migration for alerting, added try/catch logic to avoid failing Kibana on start

* fixed due to comments

* removed unused logger

* fixed type checks

* did renaming from 7.9 to 7.10

* Added migration failure unit test
@YulNaumenko YulNaumenko mentioned this pull request Sep 4, 2020
Merged
jloleysens added a commit to jloleysens/kibana that referenced this pull request Sep 4, 2020
@jloleysens
Merge branch 'master' of github.com:elastic/kibana into ingest-node/g…
8f365fa 
…rok/new-patterns-component-use-array

* 'master' of github.com:elastic/kibana: (75 commits)
  Remove legacy ui-apps-mixin (elastic#76604)
  remove unused test_utils (elastic#76528)
  [ML] Functional tests - add UI permission tests (elastic#76368)
  [APM] @ts-error -> @ts-expect-error (elastic#76492)
  [APM] Avoid negative offset for error marker on timeline (elastic#76638)
  [Reporting] rename interfaces to align with task manager integration (elastic#76716)
  Revert back ESO migration for alerting, added try/catch logic to avoid failing Kibana on start (elastic#76220)
  Test reverting "Add plugin status API (elastic#75819)" (elastic#76707)
  [Security Solution][Detections] Removes ML Job Settings SIEM copy and fixes link to ML app for creating custom jobs (elastic#76595)
  [Maps] remove region/coordinate-maps visualizations from sample data (elastic#76399)
  [DOCS] Dashboard-first docs refresh (elastic#76194)
  Updated ServiceNow description in docs and actions management UI to contains correct info (elastic#76344)
  [DOCS] Identifies cloud settings in reporting (elastic#76691)
  [Security Solution] Refactor timeline details to use search strategy (elastic#75591)
  es-archiver: Drop invalid index settings, support --query flag  (elastic#76522)
  [DOCS] Identifies graph settings available on cloud (elastic#76661)
  Add more info about a11y tests (elastic#76045)
  [data.search.SearchSource] Remove legacy ES client APIs. (elastic#75943)
  [release notes] automatically retry on Github API 5xx errors (elastic#76447)
  [es_ui_shared] Fix eslint exhaustive deps rule (elastic#76392)
  ...
YulNaumenko added a commit that referenced this pull request Sep 4, 2020
@YulNaumenko
Revert back ESO migration for alerting, added try/catch logic to avoi…
76bbe8c 
…d failing Kibana on start (#76220) (#76733)

* Revert back ESO migration for alerting, added try/catch logic to avoid failing Kibana on start

* Revert back ESO migration for alerting, added try/catch logic to avoid failing Kibana on start

* fixed due to comments

* removed unused logger

* fixed type checks

* did renaming from 7.9 to 7.10

* Added migration failure unit test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikecote mikecote mikecote approved these changes

Assignees

@YulNaumenko YulNaumenko

Labels
Feature:Alerting release_note:skip Skip the PR/issue when compiling release notes Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) v7.10.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Alerting] Upgrade to 7.10 without migrating old alerts will result in broken alerts
4 participants
@YulNaumenko @elasticmachine @mikecote @kibanamachine