Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Maps] fix duplicate EuiPopover id's #76202

Merged
merged 6 commits into from
Aug 31, 2020
Merged

Conversation

nreese
Copy link
Contributor

@nreese nreese commented Aug 27, 2020

fixes #75216

Looks like some copy pasting left a duplicated EuiPopover id of contextMenu. This PR just replaces those with better ids. And while I was in tools_control, I converted it to TS

@nreese nreese added chore [Deprecated-Use Team:Presentation]Team:Geo Former Team Label for Geo Team. Now use Team:Presentation v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.10.0 labels Aug 27, 2020
@nreese nreese requested a review from thomasneirynck August 27, 2020 21:22
@nreese nreese requested a review from a team as a code owner August 27, 2020 21:22
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-gis (Team:Geo)

@thomasneirynck
Copy link
Contributor

@elasticmachine merge upstream

@elasticmachine
Copy link
Contributor

merge conflict between base and head

@nreese
Copy link
Contributor Author

nreese commented Aug 31, 2020

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Build metrics

async chunks size

id value diff baseline
maps 3.3MB -43.0B 3.3MB

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@nreese nreese merged commit 3dc2c70 into elastic:master Aug 31, 2020
nreese added a commit to nreese/kibana that referenced this pull request Aug 31, 2020
* [Maps] fix duplicate ID's

* tslint cleanup

* use layer id instead of layer name for popover id

* tslint fixes

Co-authored-by: Elastic Machine <[email protected]>
nreese added a commit that referenced this pull request Aug 31, 2020
* [Maps] fix duplicate ID's

* tslint cleanup

* use layer id instead of layer name for popover id

* tslint fixes

Co-authored-by: Elastic Machine <[email protected]>

Co-authored-by: Elastic Machine <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore [Deprecated-Use Team:Presentation]Team:Geo Former Team Label for Geo Team. Now use Team:Presentation release_note:skip Skip the PR/issue when compiling release notes v7.10.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

(Accessibility) Maps - Duplicate ID's
4 participants