Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ML] DF Analytics jobs list: improve job details analysis stats view in expanded row #76196

Merged
merged 4 commits into from
Sep 2, 2020
Merged

[ML] DF Analytics jobs list: improve job details analysis stats view in expanded row #76196

merged 4 commits into from
Sep 2, 2020

Conversation

alvarezmelissa87
Copy link
Contributor

@alvarezmelissa87 alvarezmelissa87 commented Aug 27, 2020 •
edited
Loading

Summary

Fixes #75649

Moves the job's analysis stats info into a separate Job stats tab in the expanded row.

image

Details tab:

image

For failed/running jobs with no analysis stats yet:

image

Checklist

Delete any items that are not applicable to this PR.

@alvarezmelissa87 alvarezmelissa87 added :ml release_note:skip Skip the PR/issue when compiling release notes Feature:Data Frame Analytics ML data frame analytics features v7.10.0 labels Aug 27, 2020
@alvarezmelissa87 alvarezmelissa87 requested a review from a team as a code owner August 27, 2020 21:00
@alvarezmelissa87 alvarezmelissa87 self-assigned this Aug 27, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui (:ml)

@alvarezmelissa87 alvarezmelissa87 force-pushed the ml-dfanalytics-analysis-stats branch from c872312 to 2030a0b Compare August 31, 2020 14:50
peteharverson
peteharverson reviewed Sep 1, 2020
View reviewed changes
...n/data_frame_analytics/pages/analytics_management/components/analytics_list/expanded_row.tsx Outdated
const tabs = [
{
id: 'ml-analytics-job-details',
name: i18n.translate('xpack.ml.dataframe.analyticsList.expandedRow.tabs.jobSettingsLabel', {
defaultMessage: 'Job details',
}),
content: <ExpandedRowDetailsPane sections={[state, progress, stats]} />,
content: <ExpandedRowDetailsPane sections={sections} />,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there is too much information in the 'Job details' tab now. Maybe the content on the Stats and Analysis Stats sections should be moved out onto a new 'Stats' tab?

image

This would make it consistent with the Models list, which has a Stats tab in the expanded row.

The create_time and model_memory_limit seem to belong more on a 'Config' type panel than in 'Stats' but moving them out might be outside the scope of this PR.

Copy link
Contributor Author

@alvarezmelissa87 alvarezmelissa87 Sep 1, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@peteharverson - good call. Added the tab in 246f84299a57803af286499cab2f48c81f6be17a and updated the PR description. This is ready for a final look when you get a chance. cc @jgowdyelastic

jgowdyelastic
jgowdyelastic reviewed Sep 2, 2020
View reviewed changes
...n/data_frame_analytics/pages/analytics_management/components/analytics_list/expanded_row.tsx Outdated
description: getItemDescription(analysisStatsValues.timing_stats),
},
...Object.entries(
analysisStatsValues.parameters || analysisStatsValues.hyperparameters
Copy link
Member

@jgowdyelastic jgowdyelastic Sep 2, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just to confirm, if parameters is undefined, is hyperparameters guaranteed to be defined?

Copy link
Contributor Author

@alvarezmelissa87 alvarezmelissa87 Sep 2, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be if analysisStatsValues is defined - which we check for earlier on. I'll go ahead and add a final option in case both are undefined just to be safe, though 👍

@alvarezmelissa87 alvarezmelissa87 force-pushed the ml-dfanalytics-analysis-stats branch from 246f842 to 00417eb Compare September 2, 2020 14:58
peteharverson
peteharverson approved these changes Sep 2, 2020
View reviewed changes
Copy link
Contributor

@peteharverson peteharverson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested latest edits and LGTM.

For the future we should look to try and standardize the naming and content of the stats tabs across anomaly detection jobs, DFA jobs and models, and transforms.

jgowdyelastic
jgowdyelastic approved these changes Sep 2, 2020
View reviewed changes
Copy link
Member

@jgowdyelastic jgowdyelastic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Build metrics

async chunks size

id value diff baseline
ml 8.2MB +4.6KB 8.2MB

History

  • 💚 Build #71664 succeeded 246f84299a57803af286499cab2f48c81f6be17a
  • 💚 Build #71331 succeeded ec933092074678bcd4b08b4d2d6961a35e122919
  • 💔 Build #71296 failed 2030a0b3767e7f1c3fe39c695e050fcae9b0e71b
  • 💔 Build #71051 failed c87231250b0a9dce9964eda45b050f59ce599a0f

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@alvarezmelissa87 alvarezmelissa87 merged commit de3ddbc into elastic:master Sep 2, 2020
@alvarezmelissa87 alvarezmelissa87 mentioned this pull request Sep 2, 2020
Merged
alvarezmelissa87 added a commit to alvarezmelissa87/kibana that referenced this pull request Sep 2, 2020
@alvarezmelissa87
[ML] DF Analytics jobs list: improve job details analysis stats view …
24c16fa 
…in expanded row (elastic#76196)

* move analysis stats to own section in expanded row

* fix type errors

* move stats to separate tab in expanded row

* handle parameters and hyperparameters not defined
@alvarezmelissa87 alvarezmelissa87 deleted the ml-dfanalytics-analysis-stats branch September 2, 2020 18:28
alvarezmelissa87 added a commit that referenced this pull request Sep 2, 2020
@alvarezmelissa87
[ML] DF Analytics jobs list: improve job details analysis stats view …
f0bcbca 
…in expanded row (#76196) (#76550)

* move analysis stats to own section in expanded row

* fix type errors

* move stats to separate tab in expanded row

* handle parameters and hyperparameters not defined
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jgowdyelastic jgowdyelastic jgowdyelastic approved these changes

@peteharverson peteharverson peteharverson approved these changes

Assignees

@alvarezmelissa87 alvarezmelissa87

Labels
Feature:Data Frame Analytics ML data frame analytics features :ml release_note:skip Skip the PR/issue when compiling release notes v7.10.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[ML] DF Analytics jobs list: improve job details analysis stats view in expanded row
5 participants
@alvarezmelissa87 @elasticmachine @kibanamachine @peteharverson @jgowdyelastic