-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ML] Remove "Are you sure" from filter lists #76180
Conversation
Pinging @elastic/ml-ui (:ml) |
NOTE: The guidelines (https://elastic.github.io/eui/#/layout/modal/guidelines) also show an example like this for the singular case:
... so if we want to go that route for "Delete filter list 'myfilterlist'", that's fine by me too. |
@elasticmachine merge upstream |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
💚 Build SucceededBuild metricsasync chunks size
History
To update your PR or re-run it, just comment with: |
Summary
Per https://elastic.github.io/eui/#/guidelines/writing, we should avoid using "Are you sure" in our UI messages. This PR cleans up some machine learning "delete filter" UI text.
Checklist
Screenshots (Before)
Delete a filter list:
Delete multiple filter lists:
Screenshots (After)
Delete a filter list:
Delete multiple filter lists: