Handle indexes with no default #7588
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's possible to add indexes to Kibana without specifying one as the default. Previously we were re-using the edit index route, allowing for the id to be optional. If it was not specified, we used the defaultIndex. To handle redirecting to the create index route, we would need to throw an exception to prevent the route from rendering. Instead, this creates a new route for the landing page, which redirects to the defaultIndex or the edit index page respectively. Signed-off-by: Tyler Smalley <[email protected]>
tylersmalley
force-pushed
the
7563-default-index
branch
from
5bc4690 to
5f5a7be
Compare
|
LGTM |
|
LGTM 2 |
airow
pushed a commit
to airow/kibana
that referenced
this pull request
Feb 16, 2017
Handle indexes with no default Former-commit-id: a97184d
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's possible to add indexes to Kibana without specifying one as the default.
Previously we were re-using the edit index route, allowing for the id to be optional. If it was not specified, we used the defaultIndex. To handle redirecting to the create index route, we would need to throw an exception to prevent the route from rendering.
Instead, this creates a new route for the landing page, which redirects to the defaultIndex or the edit index page respectively.
Closes #7563