-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Monitoring] Usage collection #75878
Merged
chrisronline
merged 35 commits into
elastic:master
from
chrisronline:monitoring/telemetry
Sep 25, 2020
Merged
Changes from all commits
Commits
Show all changes
35 commits
Select commit
Hold shift + click to select a range
cc0518b
First stab at some internal telemetry
chrisronline 40be20c
Add missing files
chrisronline 89505b7
mbCount telemetry
chrisronline 70dfde0
Merge remote-tracking branch 'elastic/master' into monitoring/telemetry
chrisronline f86830a
Merge remote-tracking branch 'elastic/master' into monitoring/telemetry
chrisronline 0289496
Include more data
chrisronline 08510f0
Remove unused field
chrisronline 6bd91ee
This file isn't used
chrisronline 55f8400
Mock in tests
chrisronline b0f71fd
Add schema
chrisronline c4ed834
Store schema
chrisronline 8556915
Merge remote-tracking branch 'elastic/master' into monitoring/telemetry
chrisronline cb1851a
Use sample cluster instead
chrisronline 326732f
Fix telemetry schema
chrisronline 569b880
Fix type issues
chrisronline 9d890b9
Merge remote-tracking branch 'elastic/master' into monitoring/telemetry
chrisronline d43f908
Updates
chrisronline d517051
Fix schema and tests
chrisronline e841acf
Merge remote-tracking branch 'elastic/master' into monitoring/telemetry
chrisronline 078fb06
Add tests
chrisronline 18b409e
Add tests
chrisronline 84a9181
Go back to using an array
chrisronline fa006f2
Fix schema
chrisronline 79257a5
Add page view data
chrisronline 9b25ad2
Remove debug
chrisronline 2e341c6
Merge in master
chrisronline feb4d08
Handle loading scenario here
chrisronline 5189bd2
Add delay tracking too
chrisronline 8cf79cb
Merge remote-tracking branch 'elastic/master' into monitoring/telemetry
chrisronline 811cbe6
Add clicks for setup mode
chrisronline b45d372
Add clicks for setup mode
chrisronline 8057843
Merge remote-tracking branch 'elastic/master' into monitoring/telemetry
chrisronline 5152574
Fix beats/apm page views
chrisronline 11e1077
Merge remote-tracking branch 'elastic/master' into monitoring/telemetry
chrisronline b01ed4d
Fix typings
chrisronline File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can these page titles include dynamic names? You may not want to track every single unique page title/path a user visits, but rather just a subset of normalized ones without dynamic/variable segments.
I also recommend throwing in a 2nd track pageview but with a
delay: 15000
on the call, which shows how many clusters stayed on the page some "significant amount of time" and will allow your page views to be compared to other observability ones which are currently all doing that. (We can eventually normalize that so it happens with one call across the board consistently, but for now we are keeping it all very manual.)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jasonrhodes Great idea. I was wondering why that was there for the examples I went through.
In terms of dynamic data, this page titles will not contain that. I went through all the unique instance/node pages and ensured the tracking name just said something like
kibana_instance
. With that said, we still have the beats/apm pages in legacy formats, which I hope to resolve in #76946 before updating here