Adding method to deregister a (child) section #7586
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is there a reason you would like to throw an exception if the section doesn't exist? |
No functional reason. Just keeping it consistent with registering a section. I'm equally comfortable removing that piece of code. |
|
Ok - I vote for removing the exception as there is no harm in attempting to un-register a section which does not exist. |
|
LGTM |
airow
pushed a commit
to airow/kibana
that referenced
this pull request
Feb 16, 2017
…ister-method Adding method to deregister a (child) section Former-commit-id: ce9efff
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces the capability for deregistering a management section + unit tests for it.