Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Dashboard First] By Reference Badge #75822

Closed

Conversation

ThomThomson
Copy link
Contributor

Summary

Closes #75499

Adds a badge to embeddables that can be either by value or by reference to denote when they are by reference. A tooltip on this badge will tell the user that editing this panel can result in changes to other dashboards.

The badge only shows up in containers in edit mode

Screen Shot 2020-08-19 at 4 09 24 PM

Open Questions

The color of the badge is currently hardcoded to 'hollow' in panel_header.tsx. This should be made a configurable option for badges and notifications. Currently looking for input on the best way to accomplish that.

Checklist

Delete any items that are not applicable to this PR.

For maintainers

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Build metrics

@kbn/optimizer bundle module count

id value diff baseline
dashboard 177 +1 176

page load bundle size

id value diff baseline
dashboard 707.7KB +5.4KB 702.2KB
embeddable 431.0KB +531.0B 430.5KB
total +6.0KB

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Discuss] Custom Badge to Denote Panel By Reference
2 participants