Schedule session index cleanup task only once. #75661
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
azasypkin
added
blocker
Team:Security
legrego
approved these changes
Sep 16, 2020
|
@elasticmachine merge upstream |
💚 Build SucceededBuild metrics
History
To update your PR or re-run it, just comment with: |
|
7.x/7.10.0: 97b3863 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Temporary workaround for #75501.
In this PR we're making sure that we schedule session index cleanup task only once. This is done to avoid scheduling of the task when Task Manager isn't able to serve request yet. It's an edge case that becomes more apparent in a development setup when we frequently wipe ES data without restarting Kibana.
The root cause isn't completely clear yet and will be investigated in #75501. I don't intend to merge this PR now, it is just our backup plan if we don't manage to fix original issue in 7.10 or the problem turns out to bigger than we think.
cc @gmmorris @elastic/kibana-security