[Metrics UI] Replace uses of any introduced by Lodash 4

[Zacqary]

Summary

Closes #70728

Replaces the any castings introduced by the Lodash 4 upgrade. A lot of adding ! to the end of first() and last() calls, because Typescript doesn't realize that if (someArray.length > 0) means that first/last called on someArray won't return undefined. But there were a few cases of just needing to clarify some of the typings.

[elasticmachine]

Pinging @elastic/logs-metrics-ui (Team:logs-metrics-ui)

[weltenwort]

👀 Reviewing on behalf of @elastic/logs-metrics-ui...

[weltenwort]

Thanks for tackling this! 👍 I left some suggestions about avoiding assertions by reformulating in a readable manner. ✍️

In other places I questioned the safety of the assertions, because if the intention of the any removal is to improve type safety and the reduction of runtime errors, then simply replacing as any with ! in many places doesn't achieve that.

If that's not the goal of this PR then please feel free to ignore my nitpicky questions. 😇

[weltenwort]

This is an interesting one - even though it's semantically correct, first's and last's type signatures don't allow the compiler to infer it correctly. We could, however, try to reformulate it to something that is both readable and fully type-checked by relying on the ?. operator and the fact that first and last can handle undefined values. What do you think about

  const dateFormatter = useMemo(() => {
    const firstSeries = first(data?.series);
    const firstTimestamp = first(firstSeries?.rows)?.timestamp;
    const lastTimestamp = last(firstSeries?.rows)?.timestamp;

    if (firstTimestamp == null || lastTimestamp == null) {
      return (value: number) => `${value}`;
    }

    return niceTimeFormatter([firstTimestamp, lastTimestamp]);
  }, [data?.series]);

?

[weltenwort]

Isn't the assertion first(data.series)! risky without checking data.series.length? How about we bind the series to a name early and check it for undefined directly?

  const { criteria } = params;
  const firstSeries = first(data?.series);
  if (criteria && firstSeries) {
    const series = firstSeries.rows.reduce((acc, row) => {

[Zacqary]

I think applying some suggestions locally and some through the GitHub UI confused GitHub and now it's not showing the up-to-date code changes. Going to force push to fix

[weltenwort]

Thanks for investing the time!

[Zacqary]

@elasticmachine merge upstream

[kibanamachine]

💚 Build Succeeded

• continuous-integration/kibana-ci/pull-request
• Commit: 15982ea

Build metrics

async chunks size

id	value	diff	baseline
infra	3.6MB	+562.0B	3.6MB

History

• 💚 Build #70324 succeeded a4c331f
• 💚 Build #70063 succeeded 834ffb0
• 💛 Build #69742 was flaky 35daafa
• 💔 Build #69734 failed 68e2b0b
• 💚 Build #69516 succeeded 3940c8e

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

[kibanamachine]

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.

[kibanamachine]

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.