-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[kbn/plugin-generator] remove sao, modernize #75465
Conversation
7140049
to
94370a6
Compare
d7bb31c
to
d44c696
Compare
Pinging @elastic/kibana-operations (Team:Operations) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 for design. Just moves a single .scss file
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - pretty amazing how much faster it is as well.
…ugin helper script
💚 Build SucceededBuild metrics
History
To update your PR or re-run it, just comment with: |
Co-authored-by: spalger <[email protected]>
Co-authored-by: spalger <[email protected]>
I'm working on #63069 and keep running into the nasty edges of the old plugin generator. The generator is currently based https://saojs.org/ v0.22, and while they're working on a v2 of the library there isn't any typescript support, and I think it's a somewhat unnecessary dependency.
Instead, the plugin generator just uses vinyl-fs to operate on the files in the template directory, processing
.ejs
files with ejs, filtering out files based on what type of plugin is requested, and then passing all compatible files through prettier, before writing to the target location. This happens nice and quick, and without needing a bunch of dependencies that SAO was installing.Additional QOL changes:
-y
flag to use the defaults, likeyarn init -y
, requires passing the name via the CLIy
is supplied.