-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TaskManager] fetch more tasks to run than available capacity #75429
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
resolves elastic#65552 Currently TaskManager attempts to claim exactly the number of tasks that it has capacity for. As an optimization, we're going to change to have it request more tasks than it has capacity for. This should improve latency, as when tasks complete, there may be some of these excess tasks that can be started, as they are already claimed (they still need to be marked running). All the plumbing already handles getting more tasks than we asked for, we were just never asking for more than we needed previously.
82e30a9
to
e116e26
Compare
💔 Build Failed
Failed CI StepsTest FailuresPlugin Functional Tests.x-pack/test/plugin_api_integration/test_suites/task_manager/task_manager_integration·js.task_manager scheduling and running tasks should prioritize tasks which are called using runNowStandard Out
Stack Trace
Plugin Functional Tests.x-pack/test/plugin_api_integration/test_suites/task_manager/task_manager_integration·js.task_manager scheduling and running tasks should prioritize tasks which are called using runNowStandard Out
Stack Trace
Build metrics
History
To update your PR or re-run it, just comment with: |
no longer needed, not much of use here anyway |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #65552
Summary
Currently TaskManager attempts to claim exactly the number of tasks that
it has capacity for.
As an optimization, we're going to change to have it request more tasks than
it has capacity for. This should improve latency, as when tasks complete,
there may be some of these excess tasks that can be started, as they are
already claimed (they still need to be marked running).
All the plumbing already handles getting more tasks than we asked for, we
were just never asking for more than we needed previously.
Summarize your PR. If it involves visual changes include a screenshot or gif.
Checklist
Delete any items that are not applicable to this PR.
For maintainers