-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[data.search.SearchSource] Extract dependencies and pass them in from the service definition. #75368
[data.search.SearchSource] Extract dependencies and pass them in from the service definition. #75368
Conversation
bd2924c
to
7cc6ba5
Compare
This comment has been minimized.
This comment has been minimized.
606273f
to
c336dd1
Compare
Pinging @elastic/kibana-app-arch (Team:AppArch) |
c336dd1
to
ae56af4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
code LGTM
ae56af4
to
81feb10
Compare
This comment has been minimized.
This comment has been minimized.
1 similar comment
This comment has been minimized.
This comment has been minimized.
retest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code LGTM, CodeOwner review, checked out locally, tested in Firefox, works.
💚 Build SucceededBuild metricspage load bundle size
History
To update your PR or re-run it, just comment with: |
Part of #65069
Summary
This PR does the following:
services.ts
that are no longer neededinjectedMetadata
dependency fromSearchSource
, and instead explicitly passes the necessary values in.GetConfigFn
interface which serves as a synchronous wrapper foruiSettings.get
SearchSource
usages ofuiSettings
, instead switching them over to usegetConfig
common/field_formats
Testing
This introduces no functional changes as it is only a refactor. Areas of the UI to check for regressions include Discover, Visualize (including Vega), and Lens.
Dev Docs
The search service's
getParamsFromSearchRequest
helper has been changed to prepare for exposingSearchSource
on the server. If your plugin relies on this helper, please update the dependencies passed to it as follows: