-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Search] Remove client side shard timeout #75326
[Search] Remove client side shard timeout #75326
Conversation
@elasticmachine merge upstream |
@elasticmachine merge upstream |
…om/kibana into search/remove-client-shard-timeout
💔 Build Failed
Failed CI StepsBuild metricspage load bundle size
To update your PR or re-run it, just comment with: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm... Since msearch
doesn't follow the normal pattern of going through our server-side search strategies, then if it's removed here, then how do we ensure that the parameter is sent in our msearch
requests? We could possibly add it in the create_proxy
file and import our existing server-side getSearchParams
in the new platform. Thoughts?
Also, I think we can get rid of a couple of additional parameters that are sent, including ignore_unavailable
, rest_total_hits_as_int
, and even ignore_throttled
since they are already configured server-side. We could also move max_concurrent_shard_requests
to the server, but that might be outside the scope of this PR.
@lukeelmers Since Once we create our |
Summary
Partially resolves #75321
Checklist
Remove client side shard timeout
For maintainers