[backport] PR #7308 to 4.x #7474
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbudz
force-pushed
the
jasper/backport/7308/4.x
branch
from
2c5b2c4 to
888e720
Compare
--------- **Commit 1:** [build] Commit install/remove scripts instead of generating, stop service before removing * Original sha: 08c9897 * Authored by Jonathan Budzenski <[email protected]> on 2016-03-28T02:06:16Z **Commit 2:** [build] template user in install/remove scripts * Original sha: 5387167 * Authored by Jonathan Budzenski <[email protected]> on 2016-05-02T15:57:16Z **Commit 3:** [build] Run as group kibana * Original sha: d9a84b2 * Authored by Jonathan Budzenski <[email protected]> on 2016-05-02T16:27:58Z **Commit 4:** [build] Recursive chown optimize folder * Original sha: 07618c3 * Authored by Jonathan Budzenski <[email protected]> on 2016-05-03T15:12:04Z **Commit 5:** [build] Try service kibana stop before init script * Original sha: 83c5802 * Authored by Jonathan Budzenski <[email protected]> on 2016-05-03T15:20:16Z **Commit 6:** [build] Attempt to stop service pre-install * Original sha: 6c6e4d3 * Authored by Jonathan Budzenski <[email protected]> on 2016-05-09T19:40:05Z **Commit 7:** [build] Fail on errors * Original sha: f9033a1 * Authored by Jonathan Budzenski <[email protected]> on 2016-05-10T15:47:07Z **Commit 8:** [build] Cleanup postrm * Original sha: bab73b8 * Authored by Jonathan Budzenski <[email protected]> on 2016-05-10T18:16:51Z **Commit 9:** [build] Add comment in postrm explaining empty cases * Original sha: 4336f2b * Authored by Jonathan Budzenski <[email protected]> on 2016-05-13T15:03:22Z **Commit 10:** [build] move install to /usr/share, config to /etc/kibana * Original sha: 6d293af * Authored by Jonathan Budzenski <[email protected]> on 2016-05-25T14:12:08Z **Commit 11:** [build] consolidate package config * Original sha: 8f0be48 * Authored by Jonathan Budzenski <[email protected]> on 2016-05-25T19:21:36Z **Commit 12:** [build] Cleanup packages task * Original sha: db5ac1e * Authored by Jonathan Budzenski <[email protected]> on 2016-05-25T20:15:09Z **Commit 13:** [build] Style cleanup * Original sha: 6189c19 * Authored by Jonathan Budzenski <[email protected]> on 2016-05-25T20:19:16Z **Commit 14:** [build] template chown optimize dir * Original sha: 9213e61 * Authored by Jonathan Budzenski <[email protected]> on 2016-05-25T21:27:20Z **Commit 15:** [build] Add name and description to init scripts * Original sha: e1cb593 * Authored by Jonathan Budzenski <[email protected]> on 2016-06-07T19:48:57Z
|
@epixa this went mostly as expected. old config file stays behind, default one is written to the new location. |
|
The downside with not merging this is we lose the centralized config, several of the other backports use this. It's probably more work fix all the backports than to merge this and update paths to the old locations. |
|
Sorry, I didn't follow that. So what do you propose? |
|
Three options:
I like the second option, safest option is probably third. |
|
By "centralized config" are you referring to the info in |
|
Yeah |
|
Cool. Let's do the second one then. |
|
Closing, will open a new PR for second choice. |
cee-chen
added a commit
that referenced
this pull request
Jan 30, 2024
`v92.1.1`⏩`v92.2.1` --- ## [`v92.2.1`](https://github.com/elastic/eui/releases/v92.2.1) **Bug fixes** - Removed unintentional i18n tokens in prior release that should not have been exported ## [`v92.2.0`](https://github.com/elastic/eui/releases/v92.2.0) - Updated `EuiFlyoutResizable` with new optional `onResize` callback ([#7464](elastic/eui#7464)) **Bug fixes** - Fixed an issue in `EuiResizableContainer` where `onResizeEnd` could become a stale closure when renders occured between resize start and end, resulting in an outdated version of a consumer's `onResizeEnd` callback being called ([#7468](elastic/eui#7468)) - Fixed `EuiTextArea` to correctly fire `onChange` callbacks on clear button click ([#7473](elastic/eui#7473)) - Fixed `EuiContextMenu`'s panel titles & items to not show underlines on hover for non-interactive elements ([#7474](elastic/eui#7474)) **Deprecations** - Remove unused public `EuiHue` and `EuiSaturation` subcomponent exports. Use the parent `EuiColorPicker` component instead ([#7460](elastic/eui#7460)) - Remove unused public `EuiCommentTimeline` subcomponent export. Use the parent `EuiComment` or `EuiCommentList` components instead. ([#7467](elastic/eui#7467))
CoenWarmer
pushed a commit
to CoenWarmer/kibana
that referenced
this pull request
Feb 15, 2024
`v92.1.1`⏩`v92.2.1` --- ## [`v92.2.1`](https://github.com/elastic/eui/releases/v92.2.1) **Bug fixes** - Removed unintentional i18n tokens in prior release that should not have been exported ## [`v92.2.0`](https://github.com/elastic/eui/releases/v92.2.0) - Updated `EuiFlyoutResizable` with new optional `onResize` callback ([elastic#7464](elastic/eui#7464)) **Bug fixes** - Fixed an issue in `EuiResizableContainer` where `onResizeEnd` could become a stale closure when renders occured between resize start and end, resulting in an outdated version of a consumer's `onResizeEnd` callback being called ([elastic#7468](elastic/eui#7468)) - Fixed `EuiTextArea` to correctly fire `onChange` callbacks on clear button click ([elastic#7473](elastic/eui#7473)) - Fixed `EuiContextMenu`'s panel titles & items to not show underlines on hover for non-interactive elements ([elastic#7474](elastic/eui#7474)) **Deprecations** - Remove unused public `EuiHue` and `EuiSaturation` subcomponent exports. Use the parent `EuiColorPicker` component instead ([elastic#7460](elastic/eui#7460)) - Remove unused public `EuiCommentTimeline` subcomponent export. Use the parent `EuiComment` or `EuiCommentList` components instead. ([elastic#7467](elastic/eui#7467))
fkanout
pushed a commit
to fkanout/kibana
that referenced
this pull request
Mar 4, 2024
`v92.1.1`⏩`v92.2.1` --- ## [`v92.2.1`](https://github.com/elastic/eui/releases/v92.2.1) **Bug fixes** - Removed unintentional i18n tokens in prior release that should not have been exported ## [`v92.2.0`](https://github.com/elastic/eui/releases/v92.2.0) - Updated `EuiFlyoutResizable` with new optional `onResize` callback ([elastic#7464](elastic/eui#7464)) **Bug fixes** - Fixed an issue in `EuiResizableContainer` where `onResizeEnd` could become a stale closure when renders occured between resize start and end, resulting in an outdated version of a consumer's `onResizeEnd` callback being called ([elastic#7468](elastic/eui#7468)) - Fixed `EuiTextArea` to correctly fire `onChange` callbacks on clear button click ([elastic#7473](elastic/eui#7473)) - Fixed `EuiContextMenu`'s panel titles & items to not show underlines on hover for non-interactive elements ([elastic#7474](elastic/eui#7474)) **Deprecations** - Remove unused public `EuiHue` and `EuiSaturation` subcomponent exports. Use the parent `EuiColorPicker` component instead ([elastic#7460](elastic/eui#7460)) - Remove unused public `EuiCommentTimeline` subcomponent export. Use the parent `EuiComment` or `EuiCommentList` components instead. ([elastic#7467](elastic/eui#7467))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport PR #7308
Commit 1:
[build] Commit install/remove scripts instead of generating, stop service before removing
Commit 2:
[build] template user in install/remove scripts
Commit 3:
[build] Run as group kibana
Commit 4:
[build] Recursive chown optimize folder
Commit 5:
[build] Try service kibana stop before init script
Commit 6:
[build] Attempt to stop service pre-install
Commit 7:
[build] Fail on errors
Commit 8:
[build] Cleanup postrm
Commit 9:
[build] Add comment in postrm explaining empty cases
Commit 10:
[build] move install to /usr/share, config to /etc/kibana
Commit 11:
[build] consolidate package config
Commit 12:
[build] Cleanup packages task
Commit 13:
[build] Style cleanup
Commit 14:
[build] template chown optimize dir
Commit 15:
[build] Add name and description to init scripts