Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[App Arch]: remove legacy karma tests #74599

Merged
merged 4 commits into from
Aug 10, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
124 changes: 0 additions & 124 deletions src/plugins/kibana_utils/public/storage/__tests__/storage.js

This file was deleted.

109 changes: 109 additions & 0 deletions src/plugins/kibana_utils/public/storage/storage.test.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,109 @@
/*
* Licensed to Elasticsearch B.V. under one or more contributor
* license agreements. See the NOTICE file distributed with
* this work for additional information regarding copyright
* ownership. Elasticsearch B.V. licenses this file to you under
* the Apache License, Version 2.0 (the "License"); you may
* not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing,
* software distributed under the License is distributed on an
* "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
* KIND, either express or implied. See the License for the
* specific language governing permissions and limitations
* under the License.
*/

import { Storage } from './storage';
import { IStorage, IStorageWrapper } from './types';

const payload = { first: 'john', last: 'smith' };
const createMockStore = (): MockedKeys<IStorage> => {
let store: Record<string, any> = {};
return {
getItem: jest.fn().mockImplementation((key) => store[key]),
setItem: jest.fn().mockImplementation((key, value) => (store[key] = value)),
removeItem: jest.fn().mockImplementation((key: string) => delete store[key]),
clear: jest.fn().mockImplementation(() => (store = {})),
};
};

describe('StorageService', () => {
let storage: IStorageWrapper;
let mockStore: MockedKeys<IStorage>;

beforeEach(() => {
jest.resetAllMocks();
mockStore = createMockStore();
storage = new Storage(mockStore);
});

describe('expected API', () => {
test('should have expected methods', () => {
expect(typeof storage.get).toBe('function');
expect(typeof storage.set).toBe('function');
expect(typeof storage.remove).toBe('function');
expect(typeof storage.clear).toBe('function');
});
});

describe('call behavior', () => {
test('should call getItem on the store', () => {
storage.get('name');

expect(mockStore.getItem).toHaveBeenCalledTimes(1);
});

test('should call setItem on the store', () => {
storage.set('name', 'john smith');

expect(mockStore.setItem).toHaveBeenCalledTimes(1);
});

test('should call removeItem on the store', () => {
storage.remove('name');

expect(mockStore.removeItem).toHaveBeenCalledTimes(1);
});

test('should call clear on the store', () => {
storage.clear();

expect(mockStore.clear).toHaveBeenCalledTimes(1);
});
});

describe('json data', () => {
test('should parse JSON when reading from the store', () => {
mockStore.getItem = jest.fn().mockImplementationOnce(() => JSON.stringify(payload));

const data = storage.get('name');
expect(data).toEqual(payload);
});

test('should write JSON string to the store', () => {
const key = 'name';
const value = payload;

storage.set(key, value);
expect(mockStore.setItem).toHaveBeenCalledWith(key, JSON.stringify(value));
});
});

describe('expected responses', () => {
test('should return null when not exists', () => {
const data = storage.get('notexists');
expect(data).toBe(null);
});

test('should return null when invalid JSON', () => {
mockStore.getItem = jest.fn().mockImplementationOnce(() => 'not: json');

const data = storage.get('name');
expect(data).toBe(null);
});
});
});
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ import _ from 'lodash';
import { updateOldState } from './vis_update_state';

// eslint-disable-next-line camelcase
import { pre_6_1, since_6_1 } from './__tests__/vis_update_objs/gauge_objs';
import { pre_6_1, since_6_1 } from './vis_update_state.stub';

function watchForChanges(obj) {
const originalObject = _.cloneDeep(obj);
Expand Down