Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ML] Refactor in preparation for new es client #74552

Merged
merged 4 commits into from
Aug 11, 2020
Merged

[ML] Refactor in preparation for new es client #74552

merged 4 commits into from
Aug 11, 2020

Conversation

jgowdyelastic
Copy link
Member

@jgowdyelastic jgowdyelastic commented Aug 6, 2020 •
edited
Loading

In preparation for us moving to the new es client, this changes the request handler to return the legacy client as well as the new client.
Cleans up the routes where we were always accessing the mlClient via context.ml!.mlClient to using the legacyClient

@jgowdyelastic jgowdyelastic self-assigned this Aug 6, 2020
@jgowdyelastic jgowdyelastic added :ml non-issue Indicates to automation that a pull request should not appear in the release notes refactoring release_note:skip Skip the PR/issue when compiling release notes review v7.10.0 v8.0.0 labels Aug 6, 2020
@jgowdyelastic jgowdyelastic marked this pull request as ready for review August 6, 2020 15:50
@jgowdyelastic jgowdyelastic requested a review from a team as a code owner August 6, 2020 15:50
@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui (:ml)

qn895
qn895 reviewed Aug 6, 2020
View reviewed changes
x-pack/plugins/ml/server/routes/anomaly_detectors.ts Outdated
jobId: request.params.jobId,
});
// const results = await legacyClient.callAsInternalUser('ml.modelSnapshots', {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: commented code

@qn895
Copy link
Member

qn895 commented Aug 6, 2020 •
edited
Loading

Did a test that covered the following functionalities without running into any issues:

  • Anomaly jobs (View, create, clone, edit, delete)
  • Annotations (View, create, edit, delete)
  • Datafeed (start, stop)
  • DFA (View, create, clone, edit, delete)
  • Calendars (View, create, edit, delete)
  • Filters (View, create, edit, delete)
  • Data Visualizer

Changes also LGTM

@jgowdyelastic
Copy link
Member Author

@elasticmachine merge upstream

@jgowdyelastic
Copy link
Member Author

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Build metrics

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

alvarezmelissa87
alvarezmelissa87 approved these changes Aug 10, 2020
View reviewed changes
Copy link
Contributor

@alvarezmelissa87 alvarezmelissa87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM ⚡

@jgowdyelastic jgowdyelastic merged commit 01d8f00 into elastic:master Aug 11, 2020
@jgowdyelastic jgowdyelastic deleted the new-js-client-prep-refactor branch August 11, 2020 07:53
jgowdyelastic added a commit to jgowdyelastic/kibana that referenced this pull request Aug 11, 2020
@jgowdyelastic @elasticmachine
[ML] Refactor in preparation for new es client (elastic#74552)
80e1fd5 
* [ML] Refactor in preparation for new es client

* removing commented out code

Co-authored-by: Elastic Machine <[email protected]>
@jgowdyelastic jgowdyelastic mentioned this pull request Aug 11, 2020
Merged
gmmorris added a commit to gmmorris/kibana that referenced this pull request Aug 11, 2020
@gmmorris
Merge branch 'master' into event-log/use-alerts-actions-clients
bbc3999 
* master: (339 commits)
  [Ingest Node Pipelines] Sentence-case processor names (elastic#74645)
  Bump angular dependency from 1.7.9 to 1.8.0 (elastic#74482)
  [ML] Fixing schema for custom rule conditions (elastic#74676)
  [ML] Refactor in preparation for new es client (elastic#74552)
  [ML] Adding initial file analysis overrides (elastic#74376)
  Allow any hostname for chromium proxy bypass (elastic#74693)
  [ML] ML on Kibana Management: Add ability to pass a group ID filter to job management page (elastic#74533)
  [Metrics UI] Fix No Data preview pluralization (elastic#74399)
  [Bug][Security_Solution][Telemetry] Capitalize S in macOS (elastic#74688)
  Remove karma tests  from legacy maps (elastic#74668)
  [Ingest Manager] stop creating events-* index pattern and placeholder index (elastic#74683)
  [Enterprise Search] Update the browser/document title on plugin navigation (elastic#74392)
  [visualizations] Add i18n translation for 'No results found' (elastic#74619)
  [maps] convert vector style properties to TS (elastic#74553)
  bump geckodriver binary to 0.27 (elastic#74638)
  fix: update apm agents to catch abort requests (elastic#74658)
  [Security Solution] Resolver children pagination (elastic#74603)
  add memoryStatus to df analytics page and analytics table in management (elastic#74570)
  [Ingest Manager] Allow prerelease in package version (elastic#74452)
  [App Arch]: remove legacy karma tests (elastic#74599)
  ...
jloleysens added a commit to jloleysens/kibana that referenced this pull request Aug 11, 2020
@jloleysens
Merge branch 'master' of github.com:elastic/kibana into ingest-pipeli…
97eea65 
…nes/processor-forms-a-d

* 'master' of github.com:elastic/kibana: (26 commits)
  [Telemetry][API Integration] size_in_bytes to be a number (elastic#74664)
  [ILM] Convert node details flyout to TS (elastic#73707)
  [Ingest Node Pipelines] Sentence-case processor names (elastic#74645)
  Bump angular dependency from 1.7.9 to 1.8.0 (elastic#74482)
  [ML] Fixing schema for custom rule conditions (elastic#74676)
  [ML] Refactor in preparation for new es client (elastic#74552)
  [ML] Adding initial file analysis overrides (elastic#74376)
  Allow any hostname for chromium proxy bypass (elastic#74693)
  [ML] ML on Kibana Management: Add ability to pass a group ID filter to job management page (elastic#74533)
  [Metrics UI] Fix No Data preview pluralization (elastic#74399)
  [Bug][Security_Solution][Telemetry] Capitalize S in macOS (elastic#74688)
  Remove karma tests  from legacy maps (elastic#74668)
  [Ingest Manager] stop creating events-* index pattern and placeholder index (elastic#74683)
  [Enterprise Search] Update the browser/document title on plugin navigation (elastic#74392)
  [visualizations] Add i18n translation for 'No results found' (elastic#74619)
  [maps] convert vector style properties to TS (elastic#74553)
  bump geckodriver binary to 0.27 (elastic#74638)
  fix: update apm agents to catch abort requests (elastic#74658)
  [Security Solution] Resolver children pagination (elastic#74603)
  add memoryStatus to df analytics page and analytics table in management (elastic#74570)
  ...
jgowdyelastic added a commit that referenced this pull request Aug 11, 2020
@jgowdyelastic @elasticmachine
[ML] Refactor in preparation for new es client (#74552) (#74729)
f31bc7e 
* [ML] Refactor in preparation for new es client

* removing commented out code

Co-authored-by: Elastic Machine <[email protected]>

Co-authored-by: Elastic Machine <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alvarezmelissa87 alvarezmelissa87 alvarezmelissa87 approved these changes

@qn895 qn895 qn895 approved these changes

@peteharverson peteharverson Awaiting requested review from peteharverson

@darnautov darnautov Awaiting requested review from darnautov

@walterra walterra Awaiting requested review from walterra

Assignees

@jgowdyelastic jgowdyelastic

Labels
:ml non-issue Indicates to automation that a pull request should not appear in the release notes refactoring release_note:skip Skip the PR/issue when compiling release notes review v7.10.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jgowdyelastic @elasticmachine @qn895 @kibanamachine @alvarezmelissa87