Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] In-progress Slack notifications #74012

Merged
merged 9 commits into from
Aug 1, 2020

Conversation

brianseeders
Copy link
Contributor

@brianseeders brianseeders commented Jul 31, 2020

Closes #70881

Similar to GitHub PR comments, send a Slack notification immediately on the first error, then update it on subsequent errors and when the build completes.

Screen Shot 2020-07-31 at 5 26 52 PM

->

Screen Shot 2020-07-31 at 5 27 25 PM

@brianseeders brianseeders added v8.0.0 release_note:skip Skip the PR/issue when compiling release notes Feature:CI Continuous integration v7.10.0 v7.9.0 v6.8.11 v7.8.2 labels Jul 31, 2020
@brianseeders brianseeders marked this pull request as ready for review July 31, 2020 21:35
@brianseeders brianseeders requested a review from a team as a code owner July 31, 2020 21:35
Copy link
Contributor

@spalger spalger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, this is awesome. Super excited about this. Of course, I'm a little sick of the "".toString() nonsense that groovy requires, but I'll survive.

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Build metrics

✅ unchanged

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@brianseeders brianseeders merged commit 329a98c into elastic:master Aug 1, 2020
@brianseeders brianseeders deleted the in-progress-slack branch August 1, 2020 00:56
brianseeders added a commit to brianseeders/kibana that referenced this pull request Aug 1, 2020
brianseeders added a commit to brianseeders/kibana that referenced this pull request Aug 1, 2020
brianseeders added a commit to brianseeders/kibana that referenced this pull request Aug 1, 2020
brianseeders added a commit to brianseeders/kibana that referenced this pull request Aug 2, 2020
gmmorris added a commit to gmmorris/kibana that referenced this pull request Aug 2, 2020
* master: (39 commits)
  [Canvas][tech-debt] Rename __examples__ to __stories__ (elastic#73853)
  [Canvas] Storybook Redux Addon (elastic#73227)
  Use "Apply_filter_trigger" in "explore underlying data" action (elastic#71445)
  [maps] convert top nav config to TS (elastic#73851)
  [maps] fix fit to bounds for ES document layers with joins (elastic#73985)
  [Canvas][tech-debt] Refactor Toolbar (completes Kill Recompose.pure) (elastic#73309)
  [CI] In-progress Slack notifications (elastic#74012)
  [SIEM][Detection Engine] Fixes tags to accept characters such as AND, OR, (, ), ", * (elastic#74003)
  [SECURITY_SOLUTION][ENDPOINT] Fix host list Configuration Status cell link loosing list page/size state (elastic#73989)
  Tweak injected metadata (elastic#73990)
  Closes elastic#73998 by using `canAccessML` in the ML capabilities API to (elastic#73999)
  [SIEM] Fixes toaster errors when siemDefault index is an empty or empty spaces (elastic#73991)
  [Security Solution] Fix timeline pin event callback (elastic#73981)
  [Security Solution] Fix unexpected redirect (elastic#73969)
  [Metrics UI] Fix Metrics Explorer TSVB link to use workaround pattern (elastic#73986)
  [APM] docs: Update machine learning integration (elastic#73597)
  [Ingest Manager] Fix limited concurrency helper (elastic#73976)
  [build/sysv] fix missing env variable rename (elastic#73977)
  Fix a typo. (elastic#73948)
  [Ingest Manager] Revert fleet config concurrency rollout to rate limit (elastic#73940)
  ...
@LeeDr LeeDr added v6.8.12 and removed v6.8.11 labels Aug 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:CI Continuous integration release_note:skip Skip the PR/issue when compiling release notes v6.8.12 v7.8.2 v7.9.0 v7.10.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CI] In-progress Slack notifications
4 participants