Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Kibana issue #73932 - enrollment flyout changes #74008

Merged
merged 2 commits into from
Aug 3, 2020
Merged

Kibana issue #73932 - enrollment flyout changes #74008

merged 2 commits into from
Aug 3, 2020

Conversation

EricDavisX
Copy link
Contributor

Summary

fixes issue #73932

Discussed with Team and decided to put up a PR just to evidence the desired changes.

@EricDavisX EricDavisX added the Team:Fleet Team label for Observability Data Collection Fleet team label Jul 31, 2020
@EricDavisX EricDavisX requested review from ruflin, nchaulet and a team July 31, 2020 20:55
@elasticmachine
Copy link
Contributor

Pinging @elastic/ingest-management (Team:Ingest Management)

nchaulet
nchaulet approved these changes Aug 1, 2020
View reviewed changes
Copy link
Member

@nchaulet nchaulet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

@ruflin
Copy link
Contributor

ruflin commented Aug 3, 2020

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Build metrics

async chunks size

id value diff baseline
ingestManager 1.1MB +88.0B 1.1MB

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@EricDavisX EricDavisX added the release_note:skip Skip the PR/issue when compiling release notes label Aug 3, 2020
@EricDavisX EricDavisX merged commit 346bab3 into elastic:master Aug 3, 2020
@EricDavisX EricDavisX deleted the 73932-Enroll-Flyout branch August 3, 2020 15:17
This was referenced Aug 3, 2020
Merged
Merged
EricDavisX added a commit to EricDavisX/kibana that referenced this pull request Aug 3, 2020
@EricDavisX @elasticmachine
Kibana issue elastic#73932 - enrollment flyout changes (elastic#74008)
aea7428 
Co-authored-by: Elastic Machine <[email protected]>
EricDavisX added a commit that referenced this pull request Aug 3, 2020
@EricDavisX @elasticmachine
[7.9] Kibana issue #73932 - enrollment flyout changes (#74008) (#74099)
8456f67 
Co-authored-by: Elastic Machine <[email protected]>

Co-authored-by: Elastic Machine <[email protected]>
EricDavisX added a commit that referenced this pull request Aug 3, 2020
@EricDavisX @elasticmachine
[7.x] Kibana issue #73932 - enrollment flyout changes (#74008) (#74098)
221ed51 
Co-authored-by: Elastic Machine <[email protected]>

Co-authored-by: Elastic Machine <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nchaulet nchaulet nchaulet approved these changes

@ruflin ruflin ruflin approved these changes

Assignees
No one assigned
Labels
release_note:skip Skip the PR/issue when compiling release notes Team:Fleet Team label for Observability Data Collection Fleet team v7.9.0 v7.10.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@EricDavisX @elasticmachine @ruflin @kibanamachine @nchaulet @jen-huang