Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[7.x] [Discover] Context unskip date nanos functional tests (#73781) #73920

Merged
merged 2 commits into from
Aug 5, 2020

Conversation

kertal
Copy link
Member

@kertal kertal commented Jul 31, 2020

Backports the following commits to 7.x:

* Use _source value of timestamp for search_after since ES allows this now

* Unskip functional tests

* Remove unused convertIsoToNanosAsStr
# Conflicts:
#	src/plugins/discover/public/application/angular/context/api/utils/get_es_query_search_after.ts
#	test/functional/apps/context/_date_nanos_custom_timestamp.js
@kertal
Copy link
Member Author

kertal commented Jul 31, 2020

seems the back port of the ES PR that enabled this PR is pending : elastic/elasticsearch#60328

@kertal
Copy link
Member Author

kertal commented Aug 5, 2020

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Build metrics

async chunks size

id value diff baseline
discover 430.0KB -213.0B 430.2KB

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@kertal kertal merged commit 8aac010 into elastic:7.x Aug 5, 2020
@kertal kertal deleted the backport/7.x/pr-73781 branch August 5, 2020 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants