Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[7.x] check that pathname has been updated. ignore other parts (#73689) #73770

Merged
merged 1 commit into from
Jul 30, 2020
Merged

[7.x] check that pathname has been updated. ignore other parts (#73689) #73770

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions test/plugin_functional/test_suites/core_plugins/application_status.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
* under the License.
*/

import url from 'url';
import Url from 'url';
import expect from '@kbn/expect';
import {
AppNavLinkStatus,
Expand All @@ -28,7 +28,7 @@ import { PluginFunctionalProviderContext } from '../../services';
import '../../plugins/core_app_status/public/types';

const getKibanaUrl = (pathname?: string, search?: string) =>
url.format({
Url.format({
protocol: 'http:',
hostname: process.env.TEST_KIBANA_HOST || 'localhost',
port: process.env.TEST_KIBANA_PORT || '5620',
Expand Down Expand Up @@ -115,7 +115,8 @@ export default function ({ getService, getPageObjects }: PluginFunctionalProvide

await navigateToApp('app_status');
expect(await testSubjects.exists('appStatusApp')).to.eql(true);
expect(await browser.getCurrentUrl()).to.eql(getKibanaUrl('/app/app_status/arbitrary/path'));
const currentUrl = await browser.getCurrentUrl();
expect(Url.parse(currentUrl).pathname).to.eql('/app/app_status/arbitrary/path');
});

it('can change the state of the currently mounted app', async () => {
Expand Down