[Security Solution] Adding tests for endpoint package pipelines #73703
Conversation
jonathan-buttner
added
v8.0.0
release_note:skip
jonathan-buttner
requested review from
bkimmel,
michaelolo24 and
kqualters-elastic
|
Pinging @elastic/endpoint-data-visibility-team (Team:Endpoint Data Visibility) |
|
Pinging @elastic/endpoint-app-team (Feature:Endpoint) |
| @@ -1,2 +1,4 @@ | |||
| package_paths: | |||
| - /packages/production | |||
| - /packages/staging | |||
There was a problem hiding this comment.
The package is currently in the staging environment which is why we need this. I added the snapshot just in case we ever need to grab one from there.
| @@ -38,26 +36,10 @@ export default function resolverAPIIntegrationTests({ getService }: FtrProviderC | |||
| }); | |||
|
|
|||
| it('excludes events that have an empty entity_id field', async () => { | |||
| // first lets get the _id of the document using the parent.process.entity_id | |||
| // then we'll use the API to search for that specific document | |||
| const res = await es.search<SearchResponse<Event>>({ | |||
There was a problem hiding this comment.
Clean up based on Rob's previous comments. The _id is now saved from the bulk response.
| @@ -47,7 +47,6 @@ export default function ({ getService }: FtrProviderContext) { | |||
| '/api/ingest_manager/epm/packages/filetest/0.1.0/kibana/visualization/sample_visualization.json' | |||
| ) | |||
| .set('kbn-xsrf', 'xxx') | |||
| .expect('Content-Type', 'text/plain; charset=utf-8') | |||
There was a problem hiding this comment.
@jfsiii @skh @ruflin I'm removing these checks because it seems that they change based on the base docker container we use or between releases of the package-registry.
If I hit these apis chrome returns application/json:
https://epr.elastic.co/package/aws/0.1.1/kibana/dashboard/0eb5a6a0-694f-11ea-b0ac-95d4ecb1fecd.json
And via the ingest manager api it's application/json too:
There was a problem hiding this comment.
Skipping the tests based on Sonja's guidance.
jonathan-buttner
requested review from
skh,
jfsiii,
ruflin,
neptunian and
nchaulet
| @@ -40,7 +40,8 @@ export default function ({ getService }: FtrProviderContext) { | |||
| } | |||
| }); | |||
|
|
|||
| it('fetches a .json kibana visualization file', async function () { | |||
| // skipping because the content-type returned by the registry is application/json | |||
There was a problem hiding this comment.
I am not sure to understand but it looks to me that the issue is fixed and we should probably update the test instead no? elastic/package-registry#590
There was a problem hiding this comment.
Yes, but we can also do it in a follow-up PR and get @jonathan-buttner unblocked on this one. Either way is fine with me.
|
@elasticmachine merge upstream |
| const es = getService('es'); | ||
| const generator = new EndpointDocGenerator('data'); | ||
|
|
||
| const searchForID = async <T>(id: string) => { |
There was a problem hiding this comment.
❔ Are you marking this async just so you know it returns a Promise? I don't see it awaiting anything.
There was a problem hiding this comment.
So I think it's discouraged to do return await ...
https://eslint.org/docs/rules/no-return-await
es.search() is an async function and I want to force the caller of searchForID to await on the call.
| networkIndexData.eventsInfo[0]._id | ||
| ); | ||
| expect(eventWithBothIPs.body.hits.hits[0]._source.source.geo?.country_name).to.be( | ||
| 'United States' |
There was a problem hiding this comment.
❔ These always going to be in English, regardless of what locale it's running under?
There was a problem hiding this comment.
Yeah good point. I don't think they'd change much but for some reason the 8.8.8.8 ip address got switched to a different country this would fail. I'll switch it to check that the name isn't undefined 👍
💚 Build SucceededBuild metrics
History
To update your PR or re-run it, just comment with: |
…tic#73703) * Adding tests for endpoint package pipelines * Removing content type check on types that can change based on docker image version * Skipping ingest tests instead of remove expect * Switching ingest tests over to use application/json * Removing country names Co-authored-by: Elastic Machine <[email protected]>
…) (#73871) * Adding tests for endpoint package pipelines * Removing content type check on types that can change based on docker image version * Skipping ingest tests instead of remove expect * Switching ingest tests over to use application/json * Removing country names Co-authored-by: Elastic Machine <[email protected]> Co-authored-by: Elastic Machine <[email protected]>
This PR adds tests for the endpoint package's pipelines.
The docker image corresponds to the endpoint package v0.12.0 release in the staging environment here: elastic/package-storage@80e93ad